Add cdac CCR instructions #128502
Open
rcj1 wants to merge 3 commits into
Open
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new folder-specific instruction document intended to guide reviews/automation for the cDAC area (and reduce repetitive/spam feedback by clarifying which concerns are in-scope).
Changes:
- Add new
.github/instructionsguidance scoped tosrc/native/managed/cdac/** - Document expectations around API review signaling, DacDbi interface changes, dump compatibility, exception mapping, and documentation requirements
Show a summary per file
| File | Description |
|---|---|
.github/instructions/cdac-instructions.md |
New cDAC-scoped instructions and conventions for reviews/automation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping that this will silence some of the spam comments.