Migrate eng/pipelines from PublishBuildArtifacts to PublishPipelineArtifact#128498
Open
mmitche wants to merge 1 commit into
Open
Migrate eng/pipelines from PublishBuildArtifacts to PublishPipelineArtifact#128498mmitche wants to merge 1 commit into
mmitche wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime repo’s Azure Pipelines YAML under eng/pipelines/ to use Pipeline Artifacts (PublishPipelineArtifact@1 / DownloadPipelineArtifact@2) instead of legacy Build Artifacts, including updating shared helper templates so callers pass the correct input names.
Changes:
- Replace
PublishBuildArtifacts@1withPublishPipelineArtifact@1(and 1ES equivalents) and update inputs (pathtoPublish/PathtoPublish/pathToPublish→targetPath). - Replace
DownloadBuildArtifacts@0withDownloadPipelineArtifact@2and update download destinations (downloadPath→targetPath). - Update perf templates’ binlog artifact naming to include
_Attempt$(System.JobAttempt)to avoid retry collisions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/performance/templates/build-perf-sample-apps.yml | Switch binlog publishing to Pipeline Artifacts and suffix names with job attempt. |
| eng/pipelines/performance/templates/build-perf-maui-apps-net7.yml | Switch MAUI binlog publishing to Pipeline Artifacts with attempt-suffixed artifact names. |
| eng/pipelines/performance/templates/build-perf-maui-apps-net6.yml | Switch MAUI binlog publishing to Pipeline Artifacts with attempt-suffixed artifact names. |
| eng/pipelines/performance/templates/build-perf-bdn-app.yml | Switch Benchmarks.Droid binlog publishing to Pipeline Artifacts with attempt-suffixed artifact name. |
| eng/pipelines/common/wasm-post-build-steps.yml | Publish WASM intermediate artifacts/WBT via Pipeline Artifacts (stable names). |
| eng/pipelines/common/upload-intermediate-artifacts-step.yml | Update intermediate artifact publish helper to pass Pipeline Artifact inputs. |
| eng/pipelines/common/upload-artifact-step.yml | Update shared archive+publish helper to publish Pipeline Artifacts (uses targetPath). |
| eng/pipelines/common/templates/publish-build-artifacts.yml | Replace build-artifact publish wrapper with pipeline-artifact publish wrapper. |
| eng/pipelines/common/templates/browser-wasm-coreclr-build-tests.yml | Migrate artifact downloads to DownloadPipelineArtifact@2 with explicit targetPath. |
| eng/pipelines/common/templates/browser-wasm-build-tests.yml | Migrate artifact downloads to DownloadPipelineArtifact@2 with explicit targetPath. |
| eng/pipelines/common/download-specific-artifact-step.yml | Migrate “download specific run” helper to DownloadPipelineArtifact@2 and update input names. |
| eng/pipelines/common/download-artifact-step.yml | Migrate “download current run” helper to DownloadPipelineArtifact@2 and update to targetPath. |
Comment on lines
+69
to
72
| # - task: DownloadPipelineArtifact@2 | ||
| # displayName: Download built nugets for multi-threaded runtime | ||
| # inputs: | ||
| # buildType: current |
Comment on lines
24
to
31
| - template: /eng/pipelines/common/templates/publish-build-artifacts.yml | ||
| parameters: | ||
| isOfficialBuild: ${{ parameters.isOfficialBuild }} | ||
| displayName: 'Publish ${{ parameters.displayName }}' | ||
| inputs: | ||
| PathtoPublish: $(Build.StagingDirectory)/${{ parameters.artifactName }}${{ parameters.archiveExtension }} | ||
| artifactName: ${{ parameters.artifactName }} | ||
| targetPath: $(Build.StagingDirectory)/${{ parameters.artifactName }}${{ parameters.archiveExtension }} | ||
| artifactName: ${{ parameters.artifactName }} | ||
| condition: ${{ parameters.condition }} |
Member
Author
|
This will for sure need some scrutiny but should start to cut some time off PR builds. |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all remaining
PublishBuildArtifacts@1/DownloadBuildArtifacts@0usage ineng/pipelines/toPublishPipelineArtifact@1/DownloadPipelineArtifact@2.Pipeline Artifacts use dedup-based upload and are 10-100x faster than legacy Build Artifacts. This migration reduces agent time spent on artifact publishing and returns agents to the pool sooner, reducing queue pressure for all pipelines sharing the same pools.
Artifact naming strategy
Pipeline Artifacts cannot be overwritten on retry (unlike Build Artifacts), so artifact names must account for
System.JobAttempt:_Attempt$(System.JobAttempt)to avoid collisions on retrysucceeded()so retries can publish cleanlyChanges
Publish wrapper
eng/pipelines/common/templates/publish-build-artifacts.yml:PublishBuildArtifacts@1/1ES.PublishBuildArtifacts@1→PublishPipelineArtifact@1/1ES.PublishPipelineArtifact@1upload-artifact-step.yml,upload-intermediate-artifacts-step.yml: updated input names (PathtoPublish→targetPath, etc.)WASM
wasm-post-build-steps.yml: 2 direct calls migrated; stable artifact names preserved for downstream consumptionPerformance templates
build-perf-sample-apps.yml: 10 binlog publish steps →_Attempt$(System.JobAttempt)suffix (diagnostic)build-perf-bdn-app.yml: 1 binlog →_Attemptsuffixbuild-perf-maui-apps-net6.yml,build-perf-maui-apps-net7.yml: 6 binlogs each →_AttemptsuffixDownloads
download-artifact-step.yml,download-specific-artifact-step.yml,browser-wasm-build-tests.yml,browser-wasm-coreclr-build-tests.yml: migrated toDownloadPipelineArtifact@2Not changed
eng/common/files (managed by Arcade; thetemplates/job/job.ymlwrapper already routesenablePublishBuildArtifactsthroughpublish-pipeline-artifactswith_Attemptsuffix)enablePublishBuildArtifacts: trueparameter references in SuperPMI/libraries templates (parameter name only; already handled by Arcade wrapper)