Translate TimeOnly.Hour/Minute/Second on SQLite#38341
Conversation
Add SqliteTimeOnlyMemberTranslator mapping Hour, Minute, and Second to
strftime('%H'/'%M'/'%S'), mirroring SqliteDateOnlyMemberTranslator. TimeOnly
is stored as TEXT, so these read cleanly with no precision loss.
Sub-second members (Millisecond/Microsecond/Nanosecond), AddHours/AddMinutes,
and the TimeSpan-dependent members (Add/Subtract/FromTimeSpan, see dotnet#18844) are
left as follow-ups.
Part of dotnet#25103
|
@Aykuttonpc please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Adds SQLite translation for
TimeOnly.Hour,TimeOnly.Minute, andTimeOnly.Second, which previously threw "could not be translated".Since
TimeOnlyis stored as TEXT ("HH:MM:SS[.fffffff]"), these map cleanly tostrftime, mirroring the existingSqliteDateOnlyMemberTranslator:This enables the corresponding base tests (
Hour,Minute,Second) inTimeOnlyTranslationsSqliteTest.I kept the PR focused on the three integer members that translate without precision concerns. The remaining pieces split naturally into follow-ups:
Millisecond/Microsecond/Nanosecond) — needstrftime('%f')sub-second parsingAddHours/AddMinutes— time modifiers with 24h wrap-aroundAdd(TimeSpan)/Subtract/FromTimeSpan— depend on TimeSpan support (SQLite: Translate TimeSpan members #18844)Part of #25103