Skip to content

Catch InvalidOperationException for unpackaged WinUI3 apps in SqliteConnection #38304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −2
Open

Catch InvalidOperationException for unpackaged WinUI3 apps in SqliteConnection #38304

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61feece
Catch InvalidOperationException for "The process has no package ident…
Copilot May 21, 2026
9dd9414
Add exception filters to check HRESULT for no-package-identity errors
Copilot May 21, 2026
7a78e39
Apply suggestions from code review
AndriySvyryd May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ static SqliteConnection()
{
currentAppData = appDataType?.GetRuntimeProperty("Current")?.GetValue(null);
}
catch (TargetInvocationException)
catch (TargetInvocationException ex) when (IsNoPackageIdentityException(ex.InnerException))
{
}
catch (InvalidOperationException ex) when (IsNoPackageIdentityException(ex))
{
Comment thread
AndriySvyryd marked this conversation as resolved.
// Ignore "The process has no package identity."
}
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated

if (currentAppData != null)
Expand All @@ -104,6 +106,11 @@ static SqliteConnection()
}
}

private static bool IsNoPackageIdentityException(Exception? ex)
=> ex is InvalidOperationException or COMException
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
&& (ex.HResult == unchecked((int)0x80073D54) // APPMODEL_ERROR_NO_PACKAGE
|| ex.HResult == unchecked((int)0x8000000D)); // E_ILLEGAL_STATE_CHANGE

/// <summary>
/// Initializes a new instance of the <see cref="SqliteConnection" /> class.
/// </summary>
Expand Down
Loading