fix: catch and log spawnSync execution errors - #110
Open
Piyush0049 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This PR fixes a silent failure bug where OS-level execution errors are swallowed without any logs.
When executing the Docker Scout binary using
childProcess.spawnSync, the process can fail to spawn entirely (for example, due to anENOENTif the file is somehow missing, or anEACCESif there is a permission/execution blocker on the runner). When this happens,result.statusisnulland the actual OS error is placed inresult.error.Currently, the action only checks
result.statusand blindly exits with code 1 if it isn't a number. This leaves developers with a crashed action and absolutely zero logs explaining why it failed to start.This change simply checks for
result.errorand explicitly logs it usingcore.setFailed()before exiting, drastically improving debuggability when runner issues occur.Validation
I've successfully built the project locally and tested the compilation via
@rollup.