e2e/image: add private registry pull/push regression test#6940
Open
AryanSharma9917 wants to merge 4 commits into
Open
e2e/image: add private registry pull/push regression test#6940AryanSharma9917 wants to merge 4 commits into
AryanSharma9917 wants to merge 4 commits into
Conversation
Add private registry test infrastructure and a pull/push auth regression e2e test. Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
Author
|
Hi @vvoland , could someone please help approve the workflow runs for this PR and take a quick review pass when possible? Thanks in advance! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Thanks @AryanSharma9917! I approved the workflows |
Member
=== Failed
=== FAIL: e2e/image TestPullPushPrivateRepository (1.57s)
private_test.go:37: assertion failed: expression is false: strings.Contains(output, "requested access to the resource is denied") || strings.Contains(output, "no basic auth credentials") || strings.Contains(output, "unauthorized") || strings.Contains(output, "authentication required"): The push refers to repository [private-registry:5001/private/alpine]
Get "http://private-registry:5001/v2/": dial tcp: lookup private-registry on 127.0.0.11:53: server misbehaving
private_test.go:43: assertion failed:
Command: docker push private-registry:5001/private/alpine:test-private-pull-push
ExitCode: 1
Error: exit status 1
Stdout: The push refers to repository [private-registry:5001/private/alpine]
Stderr: Get "http://private-registry:5001/v2/": dial tcp: lookup private-registry on 127.0.0.11:53: server misbehaving
Failures:
ExitCode was 1 expected 0
Expected no error |
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
Author
|
Hi @vvoland, @thaJeztah , There were some failing checks earlier, and I’ve addressed those issues in the latest update. I’ve pushed the fixes would appreciate it if you could take another look. Since I’ve pushed updates, could the workflows be approved/triggered again so the checks can run? Thanks! |
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
This was referenced May 26, 2026
lohitkolluri
added a commit
to lohitkolluri/cli
that referenced
this pull request
May 26, 2026
Add authenticated private-registry service to the e2e compose stack, fixture auth config, and TestPullPushPrivateRepository to verify unauthenticated pull/push fails and authenticated pull/push succeeds. Fix compose volume path: paths are resolved relative to e2e/, so use ./testdata/registry/auth instead of ./e2e/testdata/... Regression coverage for docker#5963 and docker#5965. Carries forward docker#6940. Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com> Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Notes