Skip to content

Update triliovault to last requirements - #588

Merged
alexeigutium merged 1 commit into
masterfrom
update_triliovault_to_lastrrq
May 11, 2026
Merged

Update triliovault to last requirements#588
alexeigutium merged 1 commit into
masterfrom
update_triliovault_to_lastrrq

Conversation

@alexeigutium

Copy link
Copy Markdown
Contributor

BACKGROUND

This PR updates the TrilioVault Operator install/upgrade scripts to remove deprecated Helm flags and make readiness checks more reliable across newer TVK chart versions.

Recent TVK chart behavior differs from the original script assumptions (e.g., 1/1 instead of 2/2, admission webhook pod may be absent/renamed depending on chart/config). The old logic could hang indefinitely even when install was effectively healthy. This PR makes waits version-tolerant, configurable, and fail-fast with diagnostics.

Changes

  • Replaced deprecated Helm flag:
    • --atomic -> --rollback-on-failure
  • Updated post-install readiness checks in:
  • stacks/triliovault-operator/deploy.sh
  • stacks/triliovault-operator/upgrade.sh
  • Kept kubectl get pods-based progress output (so users still see READY/STATUS/AGE) while fixing blocking conditions:
    • control-plane wait now accepts any fully-ready n/n (not hardcoded 2/2)
    • admission-webhook wait no longer loops forever if the pod is absent
  • Added configurable wait knobs via env vars:
  • TVK_WEBHOOK_ABSENT_GRACE_TRIES
  • TVK_WEBHOOK_READY_TIMEOUT_TRIES
  • TVK_WEBHOOK_WAIT_INTERVAL_SECONDS
  • TVK_LICENSE_WAIT_TIMEOUT_TRIES (deploy only)
  • TVK_LICENSE_WAIT_INTERVAL_SECONDS (deploy only)
  • TVK_LICENSE_JOB_NAME (deploy only)
  • Hardened license verification in deploy.sh:
  • stop infinite waiting for tvk-license-do
  • accept success when license status becomes Active
  • emit diagnostics and fail explicitly on timeout
  • Small shell robustness fixes:
  • quote namespace usage in license status query
  • use printf for license status messages

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

@scott scott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeigutium
alexeigutium merged commit 3b6fdc7 into master May 11, 2026
2 checks passed
@alexeigutium
alexeigutium deleted the update_triliovault_to_lastrrq branch May 11, 2026 09:05
@github-actions

Copy link
Copy Markdown

👋 @alexeigutium
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants