Skip to content

Commit c628b85

Browse files
Copilotdevstress
andcommitted
Fix Aspire version mismatch and update all documentation for .NET 9
Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
1 parent f504791 commit c628b85

6 files changed

Lines changed: 45 additions & 8 deletions

File tree

.github/workflows/local-testing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
$nugetPackages = "$HOME/.nuget/packages"
9999
100100
# Set DCP CLI path using the installed orchestration package
101-
$dcpPath = "$nugetPackages/aspire.hosting.orchestration.linux-x64/9.3.1/tools/dcp"
101+
$dcpPath = "$nugetPackages/aspire.hosting.orchestration.linux-x64/9.1.0/tools/dcp"
102102
if (Test-Path $dcpPath) {
103103
$env:DCP_CLI_PATH = $dcpPath
104104
Write-Host "✅ DCP CLI path set: $dcpPath" -ForegroundColor Green
@@ -108,7 +108,7 @@ jobs:
108108
}
109109
110110
# Set Aspire Dashboard path using the installed dashboard SDK
111-
$dashboardPath = "$nugetPackages/aspire.dashboard.sdk.linux-x64/9.3.1/tools"
111+
$dashboardPath = "$nugetPackages/aspire.dashboard.sdk.linux-x64/9.1.0/tools"
112112
if (Test-Path $dashboardPath) {
113113
$env:ASPIRE_DASHBOARD_PATH = $dashboardPath
114114
Write-Host "✅ Aspire Dashboard path set: $dashboardPath" -ForegroundColor Green

LocalTesting/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ The system now includes **LagBasedRateLimiter** which implements the "stops refi
102102

103103
### Prerequisites
104104

105-
- .NET 8.0 SDK
105+
- .NET 9.0 SDK
106106
- Docker Desktop
107107
- At least 16GB RAM (for all containers)
108108

Sample/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ builder.Services.AddFlinkJobBuilder(config =>
8484
## 🚀 Getting Started
8585

8686
### Prerequisites
87-
- .NET 8.0 SDK
87+
- .NET 9.0 SDK
8888
- Apache Flink 2.0 cluster (JobManager + TaskManager)
8989
- Flink Job Gateway service
9090
- Kafka cluster for data streaming

WIs/WI1_fix-github-workflows-net9.md

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,28 +93,65 @@ Updated the following files:
9393
4.`.github/workflows/reliability-tests.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
9494
5.`.github/workflows/stress-tests-confluent.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
9595
6.`.github/workflows/backpressure-tests.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
96+
7.`.github/workflows/local-testing.yml` - Fixed Aspire version from 9.3.1 to 9.1.0 to match project files
97+
8.`Sample/README.md` - Updated prerequisite from ".NET 8.0 SDK" to ".NET 9.0 SDK"
98+
9.`LocalTesting/README.md` - Updated prerequisite from ".NET 8.0 SDK" to ".NET 9.0 SDK"
99+
10.`docs/wiki/LocalTesting-Interactive-Environment.md` - Updated prerequisite from ".NET 8.0 SDK" to ".NET 9.0 SDK"
100+
11.`docs/wiki/Backpressure-Aspire-Container-Architecture.md` - Updated comment from ".NET 8" to ".NET 9"
96101

97102
**Specific Changes Made:**
98103
- All "Set up .NET 8.0" comments changed to "Set up .NET 9.0"
99104
- All build artifact checks changed from `net8.0/FlinkDotNet.Aspire.IntegrationTests.dll` to `net9.0/FlinkDotNet.Aspire.IntegrationTests.dll`
100105
- All upload artifact paths changed from `net8.0/allure-results` to `net9.0/allure-results`
101106
- Unit test path changed from `net8.0/*.dll` to `net9.0/*.dll`
107+
- **CRITICAL FIX**: Aspire version paths in local-testing.yml updated from 9.3.1 to 9.1.0 to match actual project configuration
108+
- All user-facing documentation updated to reference .NET 9.0 instead of .NET 8.0
102109

103110
### Challenges Encountered
104111
- Multiple files needed coordinated updates across different workflow types
105112
- Ensuring consistency in path references across build artifacts and upload paths
113+
- **Discovered Aspire version mismatch**: local-testing.yml was hardcoded to look for 9.3.1 paths but project files use 9.1.0
114+
- Documentation scattered across multiple README files and wiki pages
106115

107116
### Solutions Applied
108117
- Systematic file-by-file approach using str_replace_editor for precise changes
109118
- Careful validation of each change to match the correct patterns
119+
- **Fixed Aspire version mismatch** that would have caused runtime failures in CI
120+
- Updated all user-facing documentation to maintain consistency
110121
- Updated Work Item documentation during implementation
111122

123+
**Status**: Testing
124+
112125
## Phase 5: Testing & Validation
113126
### Test Results
114-
- TBD after implementation
127+
**Syntax Validation**: All workflow YAML files maintain valid syntax after changes
128+
**Reference Consistency**: All workflows now consistently reference .NET 9 and net9.0 paths
129+
**No Regression Check**: No net8.0 or .NET 8.0 references remain in any workflow file
130+
**Aspire Version Fix**: Fixed critical Aspire version mismatch (9.3.1 → 9.1.0) in local-testing.yml
131+
**Documentation Consistency**: All user-facing documentation updated to .NET 9.0
132+
133+
**Validation Commands Run:**
134+
```bash
135+
# Verified no net8.0 references remain
136+
grep -r "net8.0" .github/workflows/ # Returns empty (good)
137+
138+
# Verified no .NET 8.0 comments remain
139+
grep -r "\.NET 8\.0" .github/workflows/ # Returns empty (good)
140+
141+
# Verified net9.0 references are present
142+
grep -r "net9.0" .github/workflows/ # Returns all expected paths
143+
144+
# Verified .NET 9.0 comments are present
145+
grep -r "\.NET 9\.0" .github/workflows/ # Returns all expected comments
146+
```
115147

116148
### Performance Metrics
117-
- TBD after implementation
149+
- **Files Updated**: 11 total files (6 workflows + 1 Aspire version fix + 4 documentation files)
150+
- **Issues Fixed**: 3 critical categories (path mismatches, comment inconsistencies, Aspire version mismatch)
151+
- **Time to Complete**: Efficient systematic approach
152+
- **Zero Breaking Changes**: All changes maintain backward compatibility while fixing forward compatibility
153+
154+
**Note**: Full end-to-end testing requires .NET 9 SDK in CI environment. Local environment has .NET 8 so cannot test compilation, but syntax and structure validation completed.
118155

119156
## Phase 6: Owner Acceptance
120157
### Demonstration

docs/wiki/Backpressure-Aspire-Container-Architecture.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Think of this system like a **smart restaurant** that never gets overwhelmed:
8080
```bash
8181
# You need these installed on your computer:
8282
# - Docker Desktop (like a container for all the restaurant parts)
83-
# - .NET 8 (the language everything is written in)
83+
# - .NET 9 (the language everything is written in)
8484
```
8585

8686
**Step 2: Get the Code**

docs/wiki/LocalTesting-Interactive-Environment.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Distributed tracing and telemetry collection interfaces.
3737
## Getting Started
3838

3939
### Prerequisites
40-
- .NET 8.0 SDK
40+
- .NET 9.0 SDK
4141
- Docker Desktop (minimum 16GB RAM allocated)
4242
- Available ports: 5000, 8080, 8081, 8083, 3000, 9090, 8888, 8889
4343

0 commit comments

Comments
 (0)