Skip to content

Commit f504791

Browse files
Copilotdevstress
Copilot
and
devstress
committed
Fix all GitHub workflows for .NET 9 compatibility - update paths and comments
Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
1 parent 5ee9129 commit f504791

7 files changed

Lines changed: 38 additions & 31 deletions

File tree

‎.github/workflows/backpressure-tests.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Ensure Docker is running
2727
run: docker info
2828

29-
- name: Set up .NET 8.0
29+
- name: Set up .NET 9.0
3030
uses: actions/setup-dotnet@v4
3131
with:
3232
dotnet-version: '9.0.x'
@@ -39,7 +39,7 @@ jobs:
3939
- name: Ensure build assemblies
4040
shell: bash
4141
run: |
42-
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
42+
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
4343
echo "Build artifacts missing. Building solutions..."
4444
dotnet restore FlinkDotNet/FlinkDotNet.sln
4545
dotnet restore Sample/Sample.sln
@@ -97,8 +97,8 @@ jobs:
9797
**/*.trx
9898
**/allure-results/**
9999
**/allure-report/**
100-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-results/**
101-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-report/**
100+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-results/**
101+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-report/**
102102
103103
- name: Generate Backpressure Test Summary Report
104104
if: always()

‎.github/workflows/build.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
java-version: '17'
2828
distribution: 'zulu'
2929

30-
- name: Set up .NET 8.0
30+
- name: Set up .NET 9.0
3131
uses: actions/setup-dotnet@v4
3232
with:
3333
dotnet-version: '9.0.x'

‎.github/workflows/integration-tests.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Ensure Docker is running
2323
run: docker info
2424

25-
- name: Set up .NET 8.0
25+
- name: Set up .NET 9.0
2626
uses: actions/setup-dotnet@v4
2727
with:
2828
dotnet-version: '9.0.x'
@@ -35,7 +35,7 @@ jobs:
3535
- name: Ensure build assemblies
3636
shell: bash
3737
run: |
38-
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
38+
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
3939
echo "Build artifacts missing. Building solutions..."
4040
dotnet restore FlinkDotNet/FlinkDotNet.sln
4141
dotnet restore Sample/Sample.sln
@@ -106,5 +106,5 @@ jobs:
106106
**/*.txt
107107
**/allure-results/**
108108
**/allure-report/**
109-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-results/**
110-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-report/**
109+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-results/**
110+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-report/**

‎.github/workflows/reliability-tests.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Ensure Docker is running
2727
run: docker info
2828

29-
- name: Set up .NET 8.0
29+
- name: Set up .NET 9.0
3030
uses: actions/setup-dotnet@v4
3131
with:
3232
dotnet-version: '9.0.x'
@@ -39,7 +39,7 @@ jobs:
3939
- name: Ensure build assemblies
4040
shell: bash
4141
run: |
42-
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
42+
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
4343
echo "Build artifacts missing. Building solutions..."
4444
dotnet restore FlinkDotNet/FlinkDotNet.sln
4545
dotnet restore Sample/Sample.sln
@@ -94,5 +94,5 @@ jobs:
9494
**/*.trx
9595
**/allure-results/**
9696
**/allure-report/**
97-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-results/**
98-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-report/**
97+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-results/**
98+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-report/**

‎.github/workflows/stress-tests-confluent.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Ensure Docker is running
2727
run: docker info
2828

29-
- name: Set up .NET 8.0
29+
- name: Set up .NET 9.0
3030
uses: actions/setup-dotnet@v4
3131
with:
3232
dotnet-version: '9.0.x'
@@ -39,7 +39,7 @@ jobs:
3939
- name: Ensure build assemblies
4040
shell: bash
4141
run: |
42-
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
42+
if [ ! -f Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/FlinkDotNet.Aspire.IntegrationTests.dll ]; then
4343
echo "Build artifacts missing. Building solutions..."
4444
dotnet restore FlinkDotNet/FlinkDotNet.sln
4545
dotnet restore Sample/Sample.sln
@@ -94,5 +94,5 @@ jobs:
9494
**/*.trx
9595
**/allure-results/**
9696
**/allure-report/**
97-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-results/**
98-
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net8.0/allure-report/**
97+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-results/**
98+
Sample/FlinkDotNet.Aspire.IntegrationTests/bin/Release/net9.0/allure-report/**

‎.github/workflows/unit-tests.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
with:
2020
fetch-depth: 0
2121

22-
- name: Set up .NET 8.0
22+
- name: Set up .NET 9.0
2323
uses: actions/setup-dotnet@v4
2424
with:
2525
dotnet-version: '9.0.x'
@@ -38,7 +38,7 @@ jobs:
3838
- name: Ensure build assemblies
3939
shell: bash
4040
run: |
41-
if [ ! -f FlinkDotNet/*/bin/Release/net8.0/*.dll ]; then
41+
if [ ! -f FlinkDotNet/*/bin/Release/net9.0/*.dll ]; then
4242
echo "Build artifacts missing. Building solutions..."
4343
dotnet restore FlinkDotNet/FlinkDotNet.sln
4444
dotnet restore Sample/Sample.sln

‎WIs/WI1_fix-github-workflows-net9.md‎

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
**Type**: Bug Fix
99
**Assignee**: AI Agent
1010
**Created**: 2024-12-28
11-
**Status**: Investigation
11+
**Status**: Implementation
1212

1313
## Lessons Applied from Previous WIs
1414
### Previous WI References
@@ -86,21 +86,28 @@ Update all GitHub workflow files to properly reference .NET 9 and `net9.0` paths
8686

8787
## Phase 4: Implementation
8888
### Code Changes
89-
Will update the following files:
90-
1. `.github/workflows/build.yml` - comment update
91-
2. `.github/workflows/unit-tests.yml` - comment + build artifact path
92-
3. `.github/workflows/integration-tests.yml` - comment + build artifact paths + upload paths
93-
4. `.github/workflows/reliability-tests.yml` - comment + build artifact paths + upload paths
94-
5. `.github/workflows/stress-tests-confluent.yml` - comment + build artifact paths + upload paths
95-
6. `.github/workflows/backpressure-tests.yml` - comment + build artifact paths + upload paths
89+
Updated the following files:
90+
1. ✅ `.github/workflows/build.yml` - Updated comment from "Set up .NET 8.0" to "Set up .NET 9.0"
91+
2. ✅ `.github/workflows/unit-tests.yml` - Updated comment + build artifact path from `net8.0` to `net9.0`
92+
3. ✅ `.github/workflows/integration-tests.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
93+
4. ✅ `.github/workflows/reliability-tests.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
94+
5. ✅ `.github/workflows/stress-tests-confluent.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
95+
6. ✅ `.github/workflows/backpressure-tests.yml` - Updated comment + build artifact paths + upload paths from `net8.0` to `net9.0`
96+
97+
**Specific Changes Made:**
98+
- All "Set up .NET 8.0" comments changed to "Set up .NET 9.0"
99+
- All build artifact checks changed from `net8.0/FlinkDotNet.Aspire.IntegrationTests.dll` to `net9.0/FlinkDotNet.Aspire.IntegrationTests.dll`
100+
- All upload artifact paths changed from `net8.0/allure-results` to `net9.0/allure-results`
101+
- Unit test path changed from `net8.0/*.dll` to `net9.0/*.dll`
96102

97103
### Challenges Encountered
98-
- Multiple files need coordinated updates
99-
- Need to ensure no paths are missed
104+
- Multiple files needed coordinated updates across different workflow types
105+
- Ensuring consistency in path references across build artifacts and upload paths
100106

101107
### Solutions Applied
102-
- Systematic file-by-file approach
103-
- Careful validation of each change
108+
- Systematic file-by-file approach using str_replace_editor for precise changes
109+
- Careful validation of each change to match the correct patterns
110+
- Updated Work Item documentation during implementation
104111

105112
## Phase 5: Testing & Validation
106113
### Test Results

0 commit comments

Comments
 (0)