jni-rs update to v0.22 - #462

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1250:17
     |
1250 | /                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1251 | |                 {
1252 | |                     if let Some(descriptor) = characteristic.descriptors.get_mut(&descriptor_uuid) {
1253 | |                         trace!("Got read event!");
...    |
1266 | |                 }
     | |_________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1250 ~                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1251 ~                     && let Some(descriptor) = characteristic.descriptors.get_mut(&descriptor_uuid) {
1252 |                         trace!("Got read event!");
 ...
1263 |                         }
1264 ~                     }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1248:9
     |
1248 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1249 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1250 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1268 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1248 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1249 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1250 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1266 |                 }
1267 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1229:9
     |
1229 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1230 | |             if let Err(e) = peripheral
1231 | |                 .event_sender
1232 | |                 .send(PeripheralEventInternal::TxPowerLevel(tx_power_level))
...    |
1237 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1229 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1230 ~             && let Err(e) = peripheral
1231 |                 .event_sender
 ...
1235 |                 error!("Error sending tx_power_level event: {}", e);
1236 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1181:13
     |
1181 | /             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1182 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1183 | |                 {
1184 | |                     if let Some(descriptor) = characteristic.descriptors.get_mut(&descriptor_uuid) {
...    |
1194 | |             }
     | |_____________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1181 ~             if let Some(service) = peripheral.services.get_mut(&service_uuid)
1182 ~                 && let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1183 |                 {
 ...
1192 |                     }
1193 ~                 }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1180:9
     |
1180 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1181 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1182 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1195 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1180 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1181 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1182 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1193 |                 }
1194 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1154:13
     |
1154 | /             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1155 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1156 | |                 {
1157 | |                     if let Some(descriptor) = characteristic.descriptors.get_mut(&descriptor_uuid) {
...    |
1168 | |             }
     | |_____________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1154 ~             if let Some(service) = peripheral.services.get_mut(&service_uuid)
1155 ~                 && let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
1156 |                 {
 ...
1166 |                     }
1167 ~                 }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1153:9
     |
1153 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1154 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1155 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1169 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1153 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1154 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1155 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1167 |                 }
1168 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1127:9
     |
1127 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1128 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1129 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1141 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1127 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1128 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1129 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1139 |                 }
1140 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1104:9
     |
1104 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1105 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1106 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1117 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1104 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1105 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1106 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1115 |                 }
1116 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:1081:9
     |
1081 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
1082 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
1083 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1094 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
1081 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
1082 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
1083 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1092 |                 }
1093 ~             }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:986:13
     |
 986 | /             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
 987 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 988 | |                 {
 989 | |                     trace!("Writing value! With kind {:?}", kind);
...    |
1025 | |             }
     | |_____________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
 986 ~             if let Some(service) = peripheral.services.get_mut(&service_uuid)
 987 ~                 && let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 988 |                 {
 ...
1023 |                     }
1024 ~                 }
     |

warning: this `if` statement can be collapsed
    --> src/corebluetooth/internal.rs:985:9
     |
 985 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
 986 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
 987 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...    |
1026 | |         }
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
     |
 985 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
 986 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
 987 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
 ...
1024 |                 }
1025 ~             }
     |

warning: this `if` statement can be collapsed
   --> src/corebluetooth/internal.rs:891:13
    |
891 | /             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
892 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
893 | |                 {
894 | |                     trace!("Got read event!");
...   |
922 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
    |
891 ~             if let Some(service) = peripheral.services.get_mut(&service_uuid)
892 ~                 && let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
893 |                 {
...
920 |                     }
921 ~                 }
    |

warning: this `if` statement can be collapsed
   --> src/corebluetooth/internal.rs:890:9
    |
890 | /         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid) {
891 | |             if let Some(service) = peripheral.services.get_mut(&service_uuid) {
892 | |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...   |
923 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
    |
890 ~         if let Some(peripheral) = self.peripherals.get_mut(&peripheral_uuid)
891 ~             && let Some(service) = peripheral.services.get_mut(&service_uuid) {
892 |                 if let Some(characteristic) = service.characteristics.get_mut(&characteristic_uuid)
...
921 |                 }
922 ~             }
    |

warning: usage of `contains_key` followed by `insert` on a `HashMap`
   --> src/corebluetooth/internal.rs:646:9
    |
646 | /         if self.peripherals.contains_key(&uuid) {
647 | |             if local_name.is_some() || advertisement_name.is_some() {
648 | |                 self.dispatch_event(CoreBluetoothEvent::DeviceUpdated {
649 | |                     uuid,
...   |
666 | |             .await;
667 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#map_entry
    = note: `#[warn(clippy::map_entry)]` on by default
help: try
    |
646 ~         if let std::collections::hash_map::Entry::Vacant(e) = self.peripherals.entry(uuid) {
647 +             // Create our channels
648 +             let (event_sender, event_receiver) = mpsc::channel(256);
649 +             e.insert(PeripheralInternal::new(peripheral, event_sender));
650 +             self.dispatch_event(CoreBluetoothEvent::DeviceDiscovered {
651 +                 uuid,
652 +                 local_name,
653 +                 advertisement_name,
654 +                 event_receiver,
655 +             })
656 +             .await;
657 +         } else {
658 +             if local_name.is_some() || advertisement_name.is_some() {
659 +                 self.dispatch_event(CoreBluetoothEvent::DeviceUpdated {
660 +                     uuid,
661 +                     local_name,
662 +                     advertisement_name,
663 +                 })
664 +                 .await;
665 +             }
666 +         }
    |

warning: this `if` statement can be collapsed
   --> src/corebluetooth/internal.rs:606:9
    |
606 | /         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid) {
607 | |             if let Err(e) = p
608 | |                 .event_sender
609 | |                 .send(PeripheralEventInternal::Services(services, rssi))
...   |
614 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
    |
606 ~         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid)
607 ~             && let Err(e) = p
608 |                 .event_sender
...
612 |                 error!("Error sending notification event: {}", e);
613 ~             }
    |

warning: this `if` statement can be collapsed
   --> src/corebluetooth/internal.rs:593:9
    |
593 | /         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid) {
594 | |             if let Err(e) = p
595 | |                 .event_sender
596 | |                 .send(PeripheralEventInternal::ServiceData(service_data, rssi))
...   |
601 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
    |
593 ~         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid)
594 ~             && let Err(e) = p
595 |                 .event_sender
...
599 |                 error!("Error sending notification event: {}", e);
600 ~             }
    |

warning: this `if` statement can be collapsed
   --> src/corebluetooth/internal.rs:571:9
    |
571 | /         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid) {
572 | |             if let Err(e) = p
573 | |                 .event_sender
574 | |                 .send(PeripheralEventInternal::ManufacturerData(
...   |
583 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
571 ~         if let Some(p) = self.peripherals.get_mut(&peripheral_uuid)
572 ~             && let Err(e) = p
573 |                 .event_sender
...
581 |                 error!("Error sending notification event: {}", e);
582 ~             }
    |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/corebluetooth/internal.rs:394:32
    |
394 |                         .chain(unsubscribe_future_state.into_iter());
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/59807616e1fa2540724bfbac14d7976d7e4a3860/library/core/src/iter/traits/iterator.rs:510:11
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
394 -                         .chain(unsubscribe_future_state.into_iter());
394 +                         .chain(&*unsubscribe_future_state);
    |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `VecDeque`
   --> src/corebluetooth/internal.rs:394:57
    |
394 |                         .chain(unsubscribe_future_state.into_iter());
    |                                                         ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#into_iter_on_ref

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/corebluetooth/internal.rs:393:32
    |
393 |                         .chain(subscribe_future_state.into_iter())
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/59807616e1fa2540724bfbac14d7976d7e4a3860/library/core/src/iter/traits/iterator.rs:510:11
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
393 -                         .chain(subscribe_future_state.into_iter())
393 +                         .chain(&*subscribe_future_state)
    |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `VecDeque`
   --> src/corebluetooth/internal.rs:393:55
    |
393 |                         .chain(subscribe_future_state.into_iter())
    |                                                       ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#into_iter_on_ref

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/corebluetooth/internal.rs:392:32
    |
392 |                         .chain(write_future_state.into_iter())
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/59807616e1fa2540724bfbac14d7976d7e4a3860/library/core/src/iter/traits/iterator.rs:510:11
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing the `.into_iter()`
    |
392 -                         .chain(write_future_state.into_iter())
392 +                         .chain(&*write_future_state)
    |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `VecDeque`
   --> src/corebluetooth/internal.rs:392:51
    |
392 |                         .chain(write_future_state.into_iter())
    |                                                   ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#into_iter_on_ref

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `VecDeque`
   --> src/corebluetooth/internal.rs:391:26
    |
391 |                         .into_iter()
    |                          ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default