fix: preserve align attribute on block elements during sanitization#24
Merged
Conversation
The align attribute was only allowed on <img> tags, causing <p align="center"> and <h1 align="center"> patterns (common in GitHub READMEs like mermaid-js/mermaid) to lose center alignment when converted with MarkNest. Promote align to a generic attribute so it is preserved on all safe tags. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<p align="center">,<h1 align="center">etc. were losing theiralignattribute during HTML sanitizationalignattribute was only whitelisted for<img>tags, but GitHub READMEs commonly use it on<p>,<h1>,<div>for center-aligned headers (e.g., mermaid-js/mermaid)alignfrom img-specific to a generic attribute so it's preserved on all safe tagsTest plan
preserves_align_attribute_on_block_elementstest with fixture using<p align="center">and<h1 align="center">