fix: enable deflate for zip crate to support GitHub archive extraction#15
Merged
Conversation
…xtraction GitHub zipball archives use deflate compression, but the zip crate was configured with default-features = false which disabled all decompression methods. This caused "Compression method not supported" errors when converting GitHub URLs (e.g. `convert https://github.com/user/repo`). The deflate feature uses pure Rust (flate2/rust_backend), safe for all targets including wasm32. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deflatefeature on thezipcrate (default-features = falsewas disabling all decompression)convert https://github.com/user/repofailing with "Compression method not supported"deflateuses pure Rust (flate2/rust_backend), safe for wasm32 targetTest plan
cargo run -p marknest -- convert https://github.com/karpathy/autoresearch -o out.pdfsucceeds with imagescargo check -p marknest-wasm --target wasm32-unknown-unknownpassescargo test --workspace— no new failures (1 pre-existing failure in remote asset inlining test)🤖 Generated with Claude Code