docs: fix invalid minimum dependency age example#3166
Merged
Conversation
The example used "72h", which the deno.json parser and the --minimum-dependency-age CLI flag don't accept (only ISO-8601 durations, integer minutes, dates/timestamps, or 0 are valid). The .npmrc setting accepts only an integer number of days. Fixes #3161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for
minimumDependencyAgeused"72h", but neither thedeno.jsonparser nor the--minimum-dependency-ageCLI flag acceptsthat format. The parser only takes an ISO-8601 duration (
P3D,PT72H), an integer interpreted as minutes, an absolute date orRFC3339 timestamp, or
0to disable. The.npmrcmin-release-agesetting is different again: it accepts only a whole number of days.
Updates the
deno.jsonand CLI examples toP3D, the.npmrcexample to
3, and rewrites the surrounding paragraph so the listedformats actually match what's accepted.
Fixes #3161