-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix gemma4 num attention head bugs (from #7975) #7990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
635a90d
cb84e9c
8229242
60f1a0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # DeepSpeed Team |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # DeepSpeed Team | ||
|
|
||
| from transformers import Gemma4Config | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This module-level import makes test collection fail on environments that satisfy DeepSpeed’s declared minimum ( Useful? React with 👍 / 👎. |
||
|
|
||
|
|
||
| def test_gemma4_text_config_fallback(): | ||
| config = Gemma4Config() | ||
| assert not hasattr(config, 'num_attention_heads'), \ | ||
| "Gemma4Config top-level should not have num_attention_heads" | ||
| arch_cfg = config.get_text_config() | ||
| assert hasattr(arch_cfg, 'num_attention_heads') | ||
| assert arch_cfg.num_attention_heads > 0 | ||
| assert hasattr(arch_cfg, 'num_key_value_heads') | ||
| assert arch_cfg.num_key_value_heads > 0 | ||
| assert hasattr(arch_cfg, 'num_hidden_layers') | ||
| assert arch_cfg.num_hidden_layers > 0 | ||
| assert hasattr(arch_cfg, 'hidden_size') | ||
| assert arch_cfg.hidden_size > 0 | ||
|
|
||
|
|
||
| def test_gemma4_text_config_matches_text_config(): | ||
| config = Gemma4Config() | ||
| arch_cfg = config.get_text_config() | ||
| assert arch_cfg is config.text_config | ||
| assert arch_cfg.num_attention_heads == config.text_config.num_attention_heads | ||
| assert arch_cfg.num_key_value_heads == config.text_config.num_key_value_heads | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delock please move:
tests/unit/multimodal->tests/unit/v1/multimodalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI only targets
tests/unit/v1