fix: correct 4 webapp bugs from issue #3748#14
Open
deepshekhardas wants to merge 1 commit into
Open
Conversation
- LogsListPresenter: Remove inverted ClickHouse guard that blocked valid log queries - ReplayRunDialog: Add missing replayDataFetcher.data useEffect dependency - AIFilterInput: Fix wrong fetcher state check (loading -> idle) - AgentView: Reset refs when session changes to prevent stale data bleed
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4 bugs identified in issue triggerdotdev#3748:
LogsListPresenter: Inverted ClickHouse guard - removed the CLICKHOUSE error block so ClickHouse queries proceed correctly.
ReplayRunDialog: Missing replayDataFetcher.data dependency in useEffect.
AIFilterInput: Changed fetcher state check from loading to idle.
AgentView: Added useEffect to reset refs when sessionId changes.
Summary by cubic
Fixes four webapp bugs to restore ClickHouse log queries, stabilize the replay dialog, clear the AI filter input correctly, and prevent stale agent messages when switching sessions. Addresses issue triggerdotdev#3748.
CLICKHOUSEguard so ClickHouse log queries run.replayDataFetcher.datato useEffect deps to refresh queues reliably.idle(notloading).sessionIdchange to stop stale data from carrying over.Written for commit 913f7c7. Summary will update on new commits. Review in cubic