fix: correct dtype in quantize_k_cache docstring - #143
Open
yurekami wants to merge 1 commit into
Open
Conversation
The docstring incorrectly stated the return dtype as uint8_t, but the actual implementation returns torch.float8_e4m3fn. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantize_k_cachedocstringuint8_ttofloat8_e4m3fnto match the actual implementationDetails
The docstring claimed the return tensor has dtype
uint8_t, but the code actually creates a tensor withtorch.float8_e4m3fndtype (line 20).Test plan
🤖 Generated with Claude Code