Skip to content

Add support for record id of bytes type#1152

Open
lmores wants to merge 1 commit into
dedupeio:mainfrom
lmores:update/np-dtype
Open

Add support for record id of bytes type#1152
lmores wants to merge 1 commit into
dedupeio:mainfrom
lmores:update/np-dtype

Conversation

@lmores

@lmores lmores commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Add support for id columns of type bytes.

Reason: when the primary key of a row is the output of a hashing function, the most natural data type used for the corresponding database column is simply raw bytes (e.g., the BYTEA data type in postgreSQL).

I have already successfully used this patched version of dedupe to deduplicate rows from a postgresSQL table having the primary column of type BYTEA.

Let me know if:

  1. you are interested in adding support for id columns with bytes type
  2. you prefer to keep this change under the hood (as it is now) or make it explicit and update all the typing definitions in _typing.py

@codecov

codecov Bot commented Mar 17, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (f72d4a1) to head (68aa7d7).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
dedupe/core.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   73.71%   73.65%   -0.07%     
==========================================
  Files          29       29              
  Lines        2321     2323       +2     
==========================================
  Hits         1711     1711              
- Misses        610      612       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lmores

lmores commented Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

@fgregg: any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant