server: Perform addr related tasks after handshake.#3690
Open
davecgh wants to merge 1 commit into
Open
Conversation
This moves the logic related to requesting and advertising addresses to after the handshake completes as opposed to doing it during the handshake in the version message handler. In practice, the overall effect is the same, but moving it to happen after the handshake has at least the following benefits: - It helps ensure no other messages are queued up or sent between the version and verack messages - It keeps the version handler focused on its primary purpose of negotiation and rejection of peers deemed to be unsuitable - It is easier to reason about the sequence of events
davecgh
force-pushed
the
server_addrs_after_handshake
branch
from
db09081 to
d4da7fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the logic related to requesting and advertising addresses to after the handshake completes as opposed to doing it during the handshake in the version message handler.
In practice, the overall effect is the same, but moving it to happen after the handshake has at least the following benefits: