Use trips as primary unit for filtering, cascade changes upwards, and remove nonexistent association#7
Merged
Merged
Conversation
brookeangel
force-pushed
the
trips-as-primary-unit
branch
from
November 26, 2025 16:27
cdc6e65 to
35f4720
Compare
brookeangel
force-pushed
the
trips-as-primary-unit
branch
from
November 26, 2025 17:38
35f4720 to
62d74ac
Compare
brookeangel
force-pushed
the
trips-as-primary-unit
branch
from
November 26, 2025 18:35
1621f5a to
425ba90
Compare
brookeangel
marked this pull request as ready for review
November 26, 2025 18:57
davidmh
reviewed
Nov 29, 2025
| private | ||
|
|
||
| def apply_filters(file, filters, original) | ||
| # Do not mutate the original |
Owner
There was a problem hiding this comment.
How come we avoid mutating here but we do mutate in prune!?
If useful, could we leave it as a comment in the code?
Collaborator
Author
There was a problem hiding this comment.
Yeah sorry, that is awkward! Let me see if I can better arrange, or if not, leave a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #6
This PR contains several breaking changes to existing behaviors:
See issue and tests for examples.