implement variant_get_int#51
Merged
friendlymatthew merged 3 commits intodatafusion-contrib:mainfrom Mar 15, 2026
Merged
Conversation
Contributor
Author
|
@friendlymatthew Could've been 189loc less to review without the unit tests. 🤓 |
Comment on lines
+3
to
+4
| (1, '{"name": "Alice", "age": 30}'), | ||
| (2, '{"name": "Bob", "age": 25}'), |
Member
There was a problem hiding this comment.
we should start using Alex, Dave, Van for names lol
friendlymatthew
approved these changes
Mar 14, 2026
Member
|
@sdf-jkl feel free to press the big green button |
Contributor
Author
|
@friendlymatthew I don't think I have it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variant_get_int: Initial implementation #34First wrote
variant_get_intfromvariant_get_str, then extracted same helpers fromvariant_get_intandvariant_get_strto shared.rs.