variant_get: Update some nits, add slt test cases#18
Open
friendlymatthew wants to merge 1 commit intomainfrom
Open
variant_get: Update some nits, add slt test cases#18friendlymatthew wants to merge 1 commit intomainfrom
variant_get: Update some nits, add slt test cases#18friendlymatthew wants to merge 1 commit intomainfrom
Conversation
friendlymatthew
force-pushed
the
friendlymatthew/add-variant-get-slt-test-cases
branch
from
b35db3a to
09289ba
Compare
Contributor
|
Could you update the branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains minor followups from #17 and adds a set of SLT test cases in
variant_get.sltNote: these tests currently fail, since we need to bump the arrow version