Fix license header CI by adding Apache license to Makefile#145
Merged
Conversation
Co-authored-by: waynexia <15380403+waynexia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI by adding license headers to missing files
Fix license header CI by adding Apache license to Makefile
Oct 18, 2025
waynexia
approved these changes
Oct 18, 2025
Xuanwo
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing license header CI check by adding the required Apache Software Foundation license header to the
Makefile.Problem
The hawkeye license checker (used in CI) was failing because the
Makefilewas missing the Apache 2.0 license header that is present in all other source files in the repository.Solution
Added the standard Apache 2.0 license header to the top of the
Makefile, matching the format used consistently across all other files in the codebase (Cargo.toml, .yml files, .toml files, .rs files, etc.).Verification
Verified locally by running the hawkeye license checker:
ERROR hawkeye::subcommand: subcommand.rs:110 Found missing header files: ["/github/workspace/Makefile"]INFO hawkeye::subcommand: subcommand.rs:116 No missing header file has been found.Fixes the CI failure referenced in https://github.com/datafusion-contrib/datafusion-orc/actions/runs/18605628066/job/53054331467?pr=143
Original prompt
Fixes #144
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.