-
Notifications
You must be signed in to change notification settings - Fork 167
Bump databricks-sdk-go to v0.132.0 #5237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ab9f28e
283de99
ce28031
4fe943b
ac27cd9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 11ae6f9d98f0d0838a5e53c27032f178fecc4ee0 | ||
| a499dda0f7802e37868d3f3076f62639165475d8 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,12 @@ name: tagging | |
| on: | ||
| # Manual dispatch. | ||
| workflow_dispatch: | ||
| # No inputs are required for the manual dispatch. | ||
| inputs: | ||
| packages: | ||
| description: 'Comma-separated list of packages to tag (e.g. "pkg1,pkg2"). Leave empty to tag all packages with pending releases.' | ||
| required: false | ||
| type: string | ||
| default: '' | ||
|
|
||
| # NOTE: Temporarily disable automated releases. | ||
| # | ||
|
|
@@ -31,8 +36,8 @@ jobs: | |
| github.repository == 'databricks/databricks-sdk-java' | ||
| environment: "release-is" | ||
| runs-on: | ||
| group: databricks-deco-testing-runner-group | ||
| labels: ubuntu-latest-deco | ||
| group: databricks-protected-runner-group | ||
| labels: linux-ubuntu-latest | ||
| steps: | ||
| - name: Generate GitHub App Token | ||
| id: generate-token | ||
|
|
@@ -44,6 +49,12 @@ jobs: | |
| - name: Checkout repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| # Force re-resolution of ``main`` at step time. Without | ||
| # ``ref:``, checkout pins to ``github.sha`` — the SHA frozen | ||
| # at workflow_dispatch time — which means re-running a stale | ||
| # dispatch checks out an older main even when newer commits | ||
| # exist. | ||
| ref: main | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have more background on this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I flagged this earlier (self-review note on lines 39 and 32) so it gets a real review rather than getting treated as routine codegen drift. Happy to split it into its own follow-up PR if you'd rather keep the SDK bump narrow. |
||
| fetch-depth: 0 | ||
| token: ${{ steps.generate-token.outputs.token }} | ||
|
|
||
|
|
@@ -60,4 +71,18 @@ jobs: | |
| env: | ||
| GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} | ||
| GITHUB_REPOSITORY: ${{ github.repository }} | ||
| run: uv run --locked internal/genkit/tagging.py | ||
| PACKAGES: ${{ inputs.packages }} | ||
| run: | | ||
| if [ -n "$PACKAGES" ]; then | ||
| uv run --locked internal/genkit/tagging.py --package "$PACKAGES" | ||
| else | ||
| uv run --locked internal/genkit/tagging.py | ||
| fi | ||
|
|
||
| - name: Upload created tags artifact | ||
| if: always() | ||
| uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 | ||
| with: | ||
| name: created-tags | ||
| path: created_tags.json | ||
| if-no-files-found: ignore | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,9 @@ | |
|
|
||
| ## Release v0.299.2 | ||
|
|
||
| ### Notable Changes | ||
| * Breaking change: `vector_search_endpoints` renamed `min_qps` to `target_qps` in DABs configuration and the `vector-search-endpoints` commands, following the SDK rename in v0.131.0. Update any `databricks.yml` using `min_qps:` to `target_qps:` and any CLI invocations using `--min-qps` to `--target-qps`. | ||
|
|
||
| ### CLI | ||
|
|
||
| * `databricks auth describe` now reports where U2M (`databricks-cli`) tokens are stored: `plaintext` (`~/.databricks/token-cache.json`) or `secure` (OS keyring), and the source of the choice (env var, config setting, or default). | ||
|
|
@@ -17,3 +20,4 @@ | |
| ### Dependency updates | ||
|
|
||
| * Bump Go toolchain to 1.25.10 ([#5213](https://github.com/databricks/cli/pull/5213)). | ||
| * Bump `github.com/databricks/databricks-sdk-go` from v0.128.0 to v0.132.0. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should contain a note about breaking changes in Notable changes section (min_qps -> target_qps in DABs and commands).
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a Notable Changes entry in ce28031 calling out the |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note: this file is generated by genkit, but this SDK bump also pulls in release workflow behavior changes such as the protected runner, explicit
ref: main, package-scoped dispatch input, and created-tags artifact. Please give this release-tooling change an explicit review rather than treating it as routine command/schema regeneration.