Skip to content

filer: detect notebook already-exists across both error formats #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 3 commits into from
May 6, 2026
Merged

filer: detect notebook already-exists across both error formats #5106

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111a358
filer: anchor notebook already-exists regex on RESOURCE_ALREADY_EXISTS
shreyas-goenka Apr 29, 2026
18e9322
filer: keep both old and new already-exists regexes
shreyas-goenka May 4, 2026
a8f1586
filer: simplify already-exists detection to substring match on shared…
shreyas-goenka May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libs/filer/workspace_files_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,10 @@ func (w *WorkspaceFilesClient) Write(ctx context.Context, name string, reader io
return fileAlreadyExistsError{absPath}
}

// This API returns 400 if the file already exists, when the object type is notebook
regex := regexp.MustCompile(`Path \((.*)\) already exists.`)
// This API returns 400 if the file already exists, when the object type is notebook.
// The error_code field is empty in the JSON body, so we anchor on the
// RESOURCE_ALREADY_EXISTS marker that the API embeds in the message instead.
regex := regexp.MustCompile(`RESOURCE_ALREADY_EXISTS: (\S+)`)
if aerr.StatusCode == http.StatusBadRequest && regex.MatchString(aerr.Message) {
// Parse file path from regex capture group
matches := regex.FindStringSubmatch(aerr.Message)
Expand Down
Loading