refactor(query): simplify SpillsBufferPool with owned runtime and configurable settings#19781
Merged
zhang2014 merged 11 commits intodatabendlabs:mainfrom Apr 28, 2026
Merged
Conversation
…figurable settings - SpillsBufferPool now owns a dedicated Runtime instead of borrowing GlobalIORuntime - Remove SpillTarget from public buffer pool APIs; callers no longer derive it - Add spill_buffer_pool_memory and spill_buffer_pool_workers to SpillConfig - Track buffer pool blocking time via atomic counters for observability - Simplify BufferWriter by removing SpillTarget and redundant comments - Clean up tests to use multi_thread tokio flavor
github-actions
Bot
added
the
pr-refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ffaf5413d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Docker Image for PR
|
Contributor
🤖 CI Job Analysis (Retry 2)
📊 Summary
✅ AUTO-RETRY INITIATED1 job(s) retried due to infrastructure issues (runner failures, timeouts, etc.) 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
…eateWriter ops Background workers were directly awaiting Fetch and CreateWriter ops in their event loop, blocking the worker thread for the duration of the I/O. With only 2 workers, concurrent Fetch/CreateWriter ops could starve reader_task_loop tasks (spawned via tokio::spawn onto the same runtime), causing recv_blocking() in SpillsDataReader::read() to hang indefinitely. Fix: spawn Fetch and CreateWriter as independent tasks, consistent with WriterTask and ReaderTask, so workers remain free to dequeue new ops. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f91b43173b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
zhang2014
added a commit
that referenced
this pull request
Apr 29, 2026
…figurable settings (#19781) * refactor(query): simplify SpillsBufferPool with owned runtime and configurable settings - SpillsBufferPool now owns a dedicated Runtime instead of borrowing GlobalIORuntime - Remove SpillTarget from public buffer pool APIs; callers no longer derive it - Add spill_buffer_pool_memory and spill_buffer_pool_workers to SpillConfig - Track buffer pool blocking time via atomic counters for observability - Simplify BufferWriter by removing SpillTarget and redundant comments - Clean up tests to use multi_thread tokio flavor * z * z * fix(query): prevent hang in SpillsBufferPool by spawning Fetch and CreateWriter ops Background workers were directly awaiting Fetch and CreateWriter ops in their event loop, blocking the worker thread for the duration of the I/O. With only 2 workers, concurrent Fetch/CreateWriter ops could starve reader_task_loop tasks (spawned via tokio::spawn onto the same runtime), causing recv_blocking() in SpillsDataReader::read() to hang indefinitely. Fix: spawn Fetch and CreateWriter as independent tasks, consistent with WriterTask and ReaderTask, so workers remain free to dequeue new ops. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * z * z * z * z * z * z --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(query): simplify SpillsBufferPool with owned runtime and configurable settings
Tests
Type of change
This change is