Skip to content

refactor: tune aggregate spill settings to enhance performance#19708

Merged
dqhl76 merged 3 commits intodatabendlabs:mainfrom
dqhl76:dqhl76/spill-writer-bench
Apr 20, 2026
Merged

refactor: tune aggregate spill settings to enhance performance#19708
dqhl76 merged 3 commits intodatabendlabs:mainfrom
dqhl76:dqhl76/spill-writer-bench

Conversation

@dqhl76
Copy link
Copy Markdown
Collaborator

@dqhl76 dqhl76 commented Apr 13, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: tune spill settings to enhance performance

close: #19672

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-refactor this PR changes the code base without new features or bugfix label Apr 13, 2026
@dqhl76 dqhl76 force-pushed the dqhl76/spill-writer-bench branch 3 times, most recently from 2895099 to dc96b02 Compare April 15, 2026 03:55
@dqhl76 dqhl76 changed the title refactor: tune spill settings to enhance performance refactor: tune aggregate spill settings to enhance performance Apr 15, 2026
@dqhl76 dqhl76 force-pushed the dqhl76/spill-writer-bench branch from 7124f4c to 84b3138 Compare April 15, 2026 07:07
@dqhl76 dqhl76 marked this pull request as ready for review April 15, 2026 07:07
@dqhl76
Copy link
Copy Markdown
Collaborator Author

dqhl76 commented Apr 15, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84b313867e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/query/service/src/physical_plans/physical_aggregate_partial.rs
@dqhl76 dqhl76 requested a review from zhang2014 April 15, 2026 07:20
@dqhl76 dqhl76 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Docker Image for PR

  • tag: pr-19708-7d9448e-1776653800

note: this image tag is only available for internal use.

@dqhl76 dqhl76 enabled auto-merge April 20, 2026 06:19
@dqhl76 dqhl76 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into databendlabs:main with commit bd01e68 Apr 20, 2026
123 of 124 checks passed
@dqhl76 dqhl76 deleted the dqhl76/spill-writer-bench branch April 20, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perf: Aggregate spill write extremely slow (~1.18 MB/s) causing query bottleneck

2 participants