feat(portal): configurable hover effects and text links style#95
Draft
BatLeDev wants to merge 27 commits into
Draft
feat(portal): configurable hover effects and text links style#95BatLeDev wants to merge 27 commits into
BatLeDev wants to merge 27 commits into
Conversation
Apply the configured hover color to nav links, the navigation menu button and footer important-link buttons, and add an importantLinksConfig option to the footer schema to style those buttons.
… for links The `text-secondary` custom property is only emitted in assisted theme mode; manual/advanced color configs strip it, leaving the links color rule pointing at an undefined --v-theme-text-secondary. Use a nested var() fallback to the raw --v-theme-secondary so the rule always resolves, matching the getTextColorsCss precedent in lib-common-types.
…anager type-check ui's AutoImport only scans src/utils and src/composables, not portal's dirs, so shared components using the new hover helpers failed check-types. Re-export the pure portal util and reimplement the composable against ui's own portal store, following the existing convention for other portal composables.
… fallback - apply buttonHoverClass/buttonHoverStyle to the contact form send button so buttonConfig.hoverColor is no longer dead there - filter topics chip hover effects to the chip-relevant subset before deriving classes/style, falling back to native darken when the resolved defaults only contain title/image effects, instead of stripping classes after the fact and losing all hover feedback - re-export portal hover utils via the #portal alias in ui/src/utils/hover.ts instead of a relative path, matching existing alias usage
…ve in manager type-check
ui/src/utils/hover.ts and the copied topics-list.vue value-import ../../../portal/app/utils/hover, but the Docker "ui" stage only copied portal/app/components and composables/agent, so `npm -w ui run build` failed in CI while passing locally. Type-only #portal imports (use-catalog) don't need the source and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make hover effects on clickable elements and the style of text links configurable, portal-wide with per-block overrides.
hoverConfigprimitive incommon-defs(effects: darken, elevate, background color, border color, title color, title underline, image zoom + a hover color) with per-field resolution: block override > portal defaults > legacy darken:focus-visible) matches hover andprefers-reduced-motiondisables transitions (RGAA)hoverColoron button configs: navigation links, menu element, contact submit button, and footer important links (which gain a fullbuttonConfig— variant, density, rounded, uppercase — defaulting to the previous rendering)linksConfig(underline always/hover/never + color) applied globally to text links (a.simple-link, markdown included), with a live preview card in the portal configurationHeads-up:
linksConfig.underlinedefaults toalways: text links on existing portals become underlined (deliberate, RGAA recommendation)portal/app/utils(cross-workspace import of the hover utils), hence the Dockerfile change