feat: migrate to taskfile - #12
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project's build system from Make to Taskfile (https://taskfile.dev), a modern task runner. The migration includes refactoring test setup code and updating CI workflows.
- Replaced Makefile with Taskfile.yml for task management
- Extracted common test environment setup into a reusable helper module
- Updated GitHub Actions workflow to use the new task runner
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Taskfile.yml | New task definition file replacing Makefile functionality |
| Makefile | Removed old Make-based build configuration |
| tests/env_helper.lua | New helper module providing reusable test environment setup |
| tests/taskfile/core_spec.lua | Refactored to use new test helper instead of duplicated setup |
| tests/taskfile/ui_spec.lua | Refactored to use new test helper instead of duplicated setup |
| .github/workflows/lint-test.yml | Updated to use task test instead of make test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| end | ||
|
|
||
| local tasks, temp_dir, taskfile_path, original_dir | ||
| local env = helpers.with_taskfile() |
There was a problem hiding this comment.
The env variable is declared but never used in this test file. Consider removing it or using it to access environment properties if needed.
| local env = helpers.with_taskfile() | |
| helpers.with_taskfile() |
| local helpers = require("tests.env_helper") | ||
|
|
||
| describe("without taskfile", function() | ||
| local env = helpers.with_empty_dir() |
There was a problem hiding this comment.
The env variable is declared but never used in the 'without taskfile' test block. Consider removing it since the test doesn't need to access environment properties.
| local env = helpers.with_empty_dir() | |
| helpers.with_empty_dir() |
| taskfile_path:rm() | ||
| vim.fn.delete(temp_dir, "rf") | ||
| end) | ||
| local env = helpers.with_taskfile() |
There was a problem hiding this comment.
The env variable is declared but never used in the 'with taskfile' test block. Consider removing it or using it to access environment properties if needed.
| local env = helpers.with_taskfile() | |
| helpers.with_taskfile() |
99e15e5 to
3d56576
Compare
No description provided.