Skip to content

fix(ffi): free transaction byte buffers correctly #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thepastaclaw wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from
+96 −24

fix(ffi): free transaction bytes with slice length

a7d48fb
Select commit
Loading
Failed to load commit list.
Draft

fix(ffi): free transaction byte buffers correctly #749

fix(ffi): free transaction bytes with slice length
a7d48fb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 9, 2026 in 1s

71.91% (+0.02%) compared to 34f574d

View this Pull Request on Codecov

71.91% (+0.02%) compared to 34f574d

Details

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.91%. Comparing base (34f574d) to head (a7d48fb).
⚠️ Report is 1 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
key-wallet-ffi/src/transaction.rs 54.16% 11 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #749      +/-   ##
=============================================
+ Coverage      71.89%   71.91%   +0.02%     
=============================================
  Files            320      320              
  Lines          69473    69465       -8     
=============================================
+ Hits           49947    49957      +10     
+ Misses         19526    19508      -18
Files with missing lines Coverage Δ
key-wallet-ffi/src/transaction.rs 2.92% <54.16%> (+2.92%) ⬆️

... and 3 files with indirect coverage changes

View more details on Codecov