modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959)#21255
Open
Mr-Charvaka wants to merge 1 commit into
Open
modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959)#21255Mr-Charvaka wants to merge 1 commit into
Mr-Charvaka wants to merge 1 commit into
Conversation
Member
|
If this PR was generated with AI assistance, please note that. What kind of testing was done? Was it only tested to make sure the problem was fixed or was testing also done to make sure there were no regressions or issues created by the fix? |
Author
|
@wpferguson I have updated the PR you can find the specific testing approach, regression safety checks, and implementation breakdown posted directly in the Pull Request description at the top of this page. |
Member
|
The goal here was to always use sigmoid for beginner workflow as this is the simplest tone mapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #20959.
Purpose & Goal
Ensure the beginner preset in Quick Access Panel (QAP) respects active user workflow preferences (
filmicrgb,agx, orsigmoid) rather than always hardcodingsigmoid.Implementation Details
src/libs/modulegroups.cto inspect the workflow configuration (plugins/darkroom/workflow).filmicrgb,agx, orsigmoidbased on active workflow settings.Testing & Verification Approach
Regression Safety
Maintains safe fallback behavior and respects existing scene-referred configuration schemes without breaking legacy presets.
Development Note
This pull request was prepared with AI-assisted pair-programming (using the Gemini-powered Antigravity agent), and has been manually reviewed and refined for correctness.