Skip to content

modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959)#21255

Open
Mr-Charvaka wants to merge 1 commit into
darktable-org:masterfrom
Mr-Charvaka:fix/issue-20959
Open

modulegroups: dynamically select tone-mapper defaults in beginner preset (fixes #20959)#21255
Mr-Charvaka wants to merge 1 commit into
darktable-org:masterfrom
Mr-Charvaka:fix/issue-20959

Conversation

@Mr-Charvaka
Copy link
Copy Markdown

@Mr-Charvaka Mr-Charvaka commented Jun 6, 2026

Resolves #20959.

Purpose & Goal

Ensure the beginner preset in Quick Access Panel (QAP) respects active user workflow preferences (filmicrgb, agx, or sigmoid) rather than always hardcoding sigmoid.

Implementation Details

  • Updated the preset initialization logic in src/libs/modulegroups.c to inspect the workflow configuration (plugins/darkroom/workflow).
  • Conditionally load filmicrgb, agx, or sigmoid based on active workflow settings.

Testing & Verification Approach

  • Verified the beginner panel configuration dynamically maps the correct modules:
    • filmic workflow -> filmicrgb
    • AgX workflow -> agx
    • sigmoid or none -> sigmoid

Regression Safety

Maintains safe fallback behavior and respects existing scene-referred configuration schemes without breaking legacy presets.

Development Note

This pull request was prepared with AI-assisted pair-programming (using the Gemini-powered Antigravity agent), and has been manually reviewed and refined for correctness.

@wpferguson
Copy link
Copy Markdown
Member

If this PR was generated with AI assistance, please note that.

What kind of testing was done? Was it only tested to make sure the problem was fixed or was testing also done to make sure there were no regressions or issues created by the fix?

@Mr-Charvaka
Copy link
Copy Markdown
Author

@wpferguson I have updated the PR you can find the specific testing approach, regression safety checks, and implementation breakdown posted directly in the Pull Request description at the top of this page.

@TurboGit
Copy link
Copy Markdown
Member

TurboGit commented Jun 7, 2026

The goal here was to always use sigmoid for beginner workflow as this is the simplest tone mapper.

@TurboGit TurboGit added the controversial this raises concerns, don't move on the technical work before reaching a consensus label Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controversial this raises concerns, don't move on the technical work before reaching a consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quck access panel: AgX workflow should have AgX module in qap instead of sigmoid

3 participants