AppImage: prefer Wayland backend, fall back to x11#21223
Open
anoderay wants to merge 1 commit into
Open
Conversation
The linuxdeploy GTK plugin hardcodes GDK_BACKEND=x11 as a workaround for older crashes. Darktable supports Wayland natively, so override this setting after the plugin runs. GTK will automatically fall back to x11 if no Wayland compositor is available.
Member
|
@anoderay : I've asked @victoryforce to have a look as he is our AppImage expert. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #21214 with generous help from claude.
The linuxdeploy GTK plugin hardcodes GDK_BACKEND=x11 as a workaround for older crashes. Darktable supports Wayland natively, so override this setting after the plugin runs. GTK will automatically fall back to x11 if no Wayland compositor is available.
As far as I understand this makes sense. I re-compiled the AppImage and it correctly launches into wayland. Also tried the AppImage in a Linux Mint XFCE VM and it doesn't break launching there.
It does however break launching darktable with GDK_BACKEND=x11 to force into x11 on wayland. Which I suppose is a corner case maybe not worth supporting.