Skip to content

Fix opencv variant collision and PyTorch 2.6 torch.load#30

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
andriiryzhkov:fix_nafnet
May 27, 2026
Merged

Fix opencv variant collision and PyTorch 2.6 torch.load#30
TurboGit merged 1 commit into
darktable-org:masterfrom
andriiryzhkov:fix_nafnet

Conversation

@andriiryzhkov

Copy link
Copy Markdown
Collaborator

Two CI failures in the conversion pipeline, both blocking the NAFNet job.

opencv collision - mmcv pulls opencv-python, albumentations pulls opencv-python-headless; both own the cv2/ namespace and race in the shared venv, leaving a half-written cv2 (no imread) that corrupts every group. Fix: standardize on headless (core requires it, an override-dependencies entry drops opencv-python). We make no GUI calls, and mmcv works with headless.

PyTorch 2.6 torch.load - 2.6 flipped weights_only to True by default, which rejects our checkpoints (they carry non-tensor config/metadata). Fix: pass weights_only=False in the NAFNet/SegNext/BSRGAN converters - trusted files we ship. Also re-enables denoise-nafnet (drops .skip).

Note: if CI caches .venv or the uv cache, bust it once - a cached env still has the corrupted cv2/ and uv sync won't repair an already-present package.

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 19de151 into darktable-org:master May 27, 2026
9 checks passed
@andriiryzhkov andriiryzhkov deleted the fix_nafnet branch May 27, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants