Skip to content

Fix YAML deserializer to bind inherited properties and handle primitive values in custom step types#1395

Open
danielgerlag with Copilot wants to merge 7 commits into
masterfrom
copilot/fix-1375
Open

Fix YAML deserializer to bind inherited properties and handle primitive values in custom step types#1395
danielgerlag with Copilot wants to merge 7 commits into
masterfrom
copilot/fix-1375

Update src/WorkflowCore.DSL/Services/DefinitionLoader.cs

b2e8967
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Oracle Test Results succeeded Oct 11, 2025 in 0s

21 passed, 1 failed and 0 skipped

Tests failed

❌ test-results/OracleTests.trx

22 tests were completed in 139s with 21 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
WorkflowCore.Tests.Oracle.OraclePersistenceProviderFixture 6✅ 6s
WorkflowCore.Tests.Oracle.Scenarios.OracleActivityScenario 1✅ 3s
WorkflowCore.Tests.Oracle.Scenarios.OracleBasicScenario 1❌ 31s
WorkflowCore.Tests.Oracle.Scenarios.OracleDataScenario 1✅ 144ms
WorkflowCore.Tests.Oracle.Scenarios.OracleDelayScenario 1✅ 13s
WorkflowCore.Tests.Oracle.Scenarios.OracleDynamicDataScenario 1✅ 125ms
WorkflowCore.Tests.Oracle.Scenarios.OracleEventScenario 1✅ 24s
WorkflowCore.Tests.Oracle.Scenarios.OracleForeachScenario 2✅ 1s
WorkflowCore.Tests.Oracle.Scenarios.OracleForkScenario 1✅ 161ms
WorkflowCore.Tests.Oracle.Scenarios.OracleIfScenario 1✅ 2s
WorkflowCore.Tests.Oracle.Scenarios.OracleRetrySagaScenario 1✅ 4s
WorkflowCore.Tests.Oracle.Scenarios.OracleSagaScenario 2✅ 345ms
WorkflowCore.Tests.Oracle.Scenarios.OracleUserScenario 1✅ 1s
WorkflowCore.Tests.Oracle.Scenarios.OracleWhenScenario 1✅ 1s
WorkflowCore.Tests.Oracle.Scenarios.OracleWhileScenario 1✅ 4s

✅ WorkflowCore.Tests.Oracle.OraclePersistenceProviderFixture

✅ ConcurrentPersistWorkflow
✅ CreateNewWorkflow_should_generate_id
✅ GetWorkflowInstance_should_retrieve_workflow
✅ GetWorkflowInstances_should_retrieve_workflows
✅ PersistWorkflow
✅ PersistWorkflow_with_subscriptions

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleActivityScenario

✅ Scenario

❌ WorkflowCore.Tests.Oracle.Scenarios.OracleBasicScenario

❌ Scenario
	Expected object to be Complete, but found Runnable.

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleDataScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleDelayScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleDynamicDataScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleEventScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleForeachScenario

✅ EmptyCollectionSequentialScenario
✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleForkScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleIfScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleRetrySagaScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleSagaScenario

✅ ExceptionScenario
✅ NoExceptionScenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleUserScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleWhenScenario

✅ Scenario

✅ WorkflowCore.Tests.Oracle.Scenarios.OracleWhileScenario

✅ Scenario

Annotations

Check failure on line 55 in test/WorkflowCore.IntegrationTests/Scenarios/BasicScenario.cs

See this annotation in the file changed.

@github-actions github-actions / Oracle Test Results

WorkflowCore.Tests.Oracle.Scenarios.OracleBasicScenario ► Scenario

Failed test found in:
  test-results/OracleTests.trx
Error:
  Expected object to be Complete, but found Runnable.
Raw output
Expected object to be Complete, but found Runnable.
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
   at FluentAssertions.Primitives.ObjectAssertions.Be(Object expected, String because, Object[] becauseArgs)
   at WorkflowCore.IntegrationTests.Scenarios.BasicScenario.Scenario() in /home/runner/work/workflow-core/workflow-core/test/WorkflowCore.IntegrationTests/Scenarios/BasicScenario.cs:line 55