feat: lionbridge connector support - #2
Open
markdaugherty wants to merge 2 commits into
Open
Conversation
Generalizes the trados-only login branch into a TOKEN_FETCHERS map keyed by service name, and adds fetchLionbridgeToken (OAuth2 client_credentials grant) so the da-nx Lionbridge connector can authenticate. Ports the change from da-sites#1 (ravuthu) onto a fork PR since we only have read access to da-sites/da-etc.
markdaugherty
marked this pull request as draft
August 10, 2026 20:50
Adds JSDoc for fetchLionbridgeToken and fetchEnvCreds, and adds the project README (endpoints, architecture, dev/deploy/config notes), updated to mention the lionbridge login route alongside trados.
markdaugherty
marked this pull request as ready for review
August 11, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picking up work on this connector from @ravuthu.
src/routes/ints.jsinto aTOKEN_FETCHERSmap keyed by service name.fetchLionbridgeToken(OAuth2 client_credentials grant) so the Lionbridge connector in adobe/da-nx#656 can authenticate.Test plan
npx eslint src/routes/ints.jspasses (verified locally)wrangler devda.live/apps/loc, using?da-etc=localto point at this route running locally): create job → upload → submit → status → download/save, all against real Lionbridge staging APIsTest site
Set up a dedicated site for this verification:
scdemos/lionbridge-demo.da/translate.json(service config: name, source language, French target,apiEndpoint/providerIdfor Lionbridge) +.da/translate-keys.json(client credentials, referenced viatranslation.service.key.path— the exact split this route'sfetchEnvCredsexpects)test-page.html) translated end-to-end via the real Translate app UI; translated copy landed at/fr/test-page.htmlas expectedCopyBackprovider (vs.Freeway) for fast, deterministic completion during testing