Fix c.CylcUIServer.log_level not working in jupyter config - #868
Fix c.CylcUIServer.log_level not working in jupyter config#868MetRonnie wants to merge 2 commits into
c.CylcUIServer.log_level not working in jupyter config#868Conversation
|
(flaky cylc review test failure unrelated: #807) |
|
Copying the context from the previous PR... The issue with this approach is that all logging is supposed to be set by the logging config, this controls everything level, handlers, adapters, streams, etc as an atomic bundle which gets applied in one go. The logging config is a reactive trait which should be able to be edited and reapplied on the fly - modifying the entire setup when it is. This PR works by hacking the logging (as set up by the logging config) in a way that will break its reactivity, but might corrupt its intention (config depending). We should really be controlling this via the logging config rather than our application-level. I haven't yet invested the time into working out how that should be done. Note, the |
Supersedes and contains one of the fixes from #789
Overriding
c.CylcUIServer.log_levelinjupyter_config.pywas not working.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.