config: load Jupyter application-specific config files

[oliver-sanders]

• Load jupyterhub_config.py files for JupyterHub.
• Load jupyter_cylc_config.py files for Jupyter Server.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• Changelog entry included if this is a change that can affect users
• Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[wxtim]

👍🏼

[oliver-sanders]

I can't see evidence of jupyter_server.py files being loaded.

Sounds like grounds to reject?

[wxtim]

I can't see evidence of jupyter_server.py files being loaded.

Sounds like grounds to reject?

Refresh page? I followed up explaining my daft mistake.

[oliver-sanders]

Refresh page? I followed up explaining my daft mistake.

No, I agree with your comment, that file ain't loaded!

It's looking for jupyter_cylc_config.py (because we're loading it through the extension it uses the extension name, not the jupyter application name)

[oliver-sanders]

@wxtim, corrected the filename and added some documentation.

Please could you double check this makes sense and the filepaths are correct (print statements in the files is a reasonable acid test).

[samuel-denton]

Suggested change

	This file configures the Hub/UIS for all users. The default path can be
	These files configure the Hub/UIS for all users. The default path can be

[samuel-denton]

Suggested change

	This file
	These files configure the Hub/UIs locally per user, overwriting global config.

I don't know if that's correct but I think it needs something there.

[samuel-denton]

It working fine for me, the correct config is loaded for the HUB vs GUI:

Other than wording updates to the README I think it's good to go.

Only thing that threw me slightly was that both new configs are located in .cylc/uiserver when there is already a directory for .cylc/hub and what appears to be it's own config (jupyter_config.py). A print statement in there is not picked up so I guess that is for something different. As long as it's documented it's fine to me.

[oliver-sanders]

there is already a directory for .cylc/hub

I don't think Cylc auto-creates this directory or file. It's not documented because it doesn't do anything to the best of my knowledge.

[samuel-denton]

We might want to add something for 'jupyter_cylc_config.py' to the README.
Does this also need a matching PR for cylc-doc for both new configs?

[samuel-denton]

there is already a directory for .cylc/hub

I don't think Cylc auto-creates this directory or file. It's not documented because it doesn't do anything to the best of my knowledge.

Ok, not sure how I've ended up with one but thats fine if it's not used.