schema: add source workflows - #512
Conversation
|
Looks fine, tests passing. |
|
Is that a formal review/approval @dwsutherland ? |
|
Getting this into subscriptions would make sense, making it easier for cylc-ui views to access this information. Would we have to add these fields in cylc-flow or could we shim them into cylc-uiserver similar to how we extend the GraphQL schema? |
Well, if we add this to the
|
|
Because this is UIS specific functionality that the Scheduler should never know about it would be better to try and keep this logic centralised in cylc-uiserver. Is is possible to extend the protobuf schema in a similar way to how we extend the GraphQL schema? |
|
Ah, so it's not about knowing the source of installed/running workflows, it's about knowing Yeah, better to keep it at UIS then, and we shouldn't need to deal with protobuf .. can just extend the subscriptions at the UIS |
|
Ok, I'll look into doing that. Would it be possible to extend the store to hold this or would I need to add a parallel store? |
|
(may as well draft this until the fields are available in subscriptions) |
123d00d to
c981964
Compare
|
(rebased) |
* Jupyter Lab views files relative to CWD. * Add source workflow paths relative to PWD to facilitate exchanging file paths with Jupyter Lab.
I've now got a use case for this which doesn't "require" the data to be available via subscriptions - opening source workflow directories in Jupyter Lab. Jupyter Lab appears only to work with relative file paths, not absolute ones, so I have added the path to the source workflow relative to the server's CWD. |
There was a problem hiding this comment.
Extending to subscriptions wouldn't be too hard, but like this I suppose you'd need to import more subscription machinery (to add it as a field of workflows sub).. Which we may end up doing more and more, the way we're heading.
Although it could just be a separate subscription (like logs etc), it shouldn't exactly change for a running workflow (?)


Add source workflows to the schema.
Unblocks cylc/cylc-ui#548, though we will probably want to extend this to subscriptions for that.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.