Simplify app toolbar - #2557
Open
MetRonnie wants to merge 5 commits into
Open
Conversation
ChrisPaulBennett
approved these changes
Jun 24, 2026
ChrisPaulBennett
left a comment
Contributor
There was a problem hiding this comment.
There is still an inconsistency between workflowID vs workflowId.
I think something is changing the case (GraphQL maybe?)
This may not actually be an issue, just thought I'd bring it up since you have altered a few of them.
Much better icons!
Member
Author
|
I was hesitant to change the GraphQL variable |
Member
Author
|
Ping @samuel-denton are you happy with these icons for the sidebar toggle button? |
Contributor
Yep I like those, consistent with everything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2542 we were not 100% agreed on the new icon for the nav sidebar. I am proposing this icon for when the sidebar is open:
and this for when it closed:
This PR also includes a few changes to eliminate technical debt that I had gradually accumulated to the point where I think we should get them in.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.