Fix flake8 ISC004 violations. - #7403
Open
hjoliver wants to merge 4 commits into
Open
Conversation
8 tasks
Member
Author
|
Yikes, the ISC004 advice (wrap intentional concatenations in parentheses) can only handle two-line concatenations. flake8-implicit-str-concat/flake8-implicit-str-concat#82 Hopefully I haven't just made an ass of myself 😁 |
MetRonnie
reviewed
Jul 28, 2026
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Member
Author
|
Good to go now @MetRonnie I guess when this gets merged, the auto sync PR will conflict with removal of setup.cfg on master and prompt us to update pyproject.toml ... |
oliver-sanders
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New flake8 fails have appeared.
https://github.com/flake8-implicit-str-concat/flake8-implicit-str-concat/releases/tag/0.7.0
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.