Skip to content

Adapt parentless spawning tests - #7374

Draft
hjoliver wants to merge 1 commit into
cylc:8.6.xfrom
hjoliver:fix-parentless-spawning-tests-2
Draft

Adapt parentless spawning tests#7374
hjoliver wants to merge 1 commit into
cylc:8.6.xfrom
hjoliver:fix-parentless-spawning-tests-2

Conversation

@hjoliver

@hjoliver hjoliver commented Jul 9, 2026

Copy link
Copy Markdown
Member

Close #7359
(Follow-up to #7237)

Notes 1: I removed Cylc 7 compat tests rather than adapting them, as they'll be removed soon anyway.

Note 2: In most start(schd) integration tests (which don't start the main loop) I ended up using a new fixture to spawn parentless tasks to the runahead limit rather than adapting the tests to work via direct manipulations of the initial task pool. This is the right thing to do because parentless tasks are logically free to spawn ahead without any other changes occurring (even though the main loop is what does that normally), and we need tests that examine the logical end-state of a given set-up or manipulation. The fixture allows that without running the main loop (which would generally evolve the task pool beyond the aforementioned state via task completion etc.).

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver changed the title Fix parentless spawning tests Adapt parentless spawning tests Jul 9, 2026
@hjoliver
hjoliver changed the base branch from master to 8.6.x July 9, 2026 04:22
@hjoliver
hjoliver marked this pull request as draft July 9, 2026 04:22
@hjoliver
hjoliver force-pushed the fix-parentless-spawning-tests-2 branch 4 times, most recently from 41131ac to 354b4f5 Compare July 14, 2026 08:20
@hjoliver
hjoliver force-pushed the fix-parentless-spawning-tests-2 branch from 354b4f5 to d373f7b Compare July 14, 2026 11:09
@hjoliver hjoliver self-assigned this Jul 14, 2026
@hjoliver hjoliver added this to the 8.6.x milestone Jul 14, 2026
@hjoliver
hjoliver marked this pull request as ready for review July 14, 2026 11:33
@MetRonnie
MetRonnie self-requested a review July 14, 2026 15:23
@hjoliver

Copy link
Copy Markdown
Member Author

and we need tests that examine the logical end-state of a given set-up or manipulation.

[w.r.t. parentless spawning to the runahead limit]

Many many tests of course make use of parentless tasks to see the effect of some action on future cycles, since they automatically spawn there without needing upstream tasks to complete.

@MetRonnie

Copy link
Copy Markdown
Member

Drafting while #7237 (comment) is yet to be addressed

@MetRonnie
MetRonnie marked this pull request as draft July 22, 2026 15:54
@hjoliver

Copy link
Copy Markdown
Member Author

Can be undrafted once #7400 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants