Adapt parentless spawning tests - #7374
Draft
hjoliver wants to merge 1 commit into
Draft
Conversation
hjoliver
marked this pull request as draft
July 9, 2026 04:22
hjoliver
force-pushed
the
fix-parentless-spawning-tests-2
branch
4 times, most recently
from
July 14, 2026 08:20
41131ac to
354b4f5
Compare
hjoliver
force-pushed
the
fix-parentless-spawning-tests-2
branch
from
July 14, 2026 11:09
354b4f5 to
d373f7b
Compare
hjoliver
marked this pull request as ready for review
July 14, 2026 11:33
MetRonnie
self-requested a review
July 14, 2026 15:23
Member
Author
[w.r.t. parentless spawning to the runahead limit] Many many tests of course make use of parentless tasks to see the effect of some action on future cycles, since they automatically spawn there without needing upstream tasks to complete. |
Member
|
Drafting while #7237 (comment) is yet to be addressed |
MetRonnie
marked this pull request as draft
July 22, 2026 15:54
Member
Author
|
Can be undrafted once #7400 is merged. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7359
(Follow-up to #7237)
Notes 1: I removed Cylc 7 compat tests rather than adapting them, as they'll be removed soon anyway.
Note 2: In most
start(schd)integration tests (which don't start the main loop) I ended up using a new fixture to spawn parentless tasks to the runahead limit rather than adapting the tests to work via direct manipulations of the initial task pool. This is the right thing to do because parentless tasks are logically free to spawn ahead without any other changes occurring (even though the main loop is what does that normally), and we need tests that examine the logical end-state of a given set-up or manipulation. The fixture allows that without running the main loop (which would generally evolve the task pool beyond the aforementioned state via task completion etc.).Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.