Remove gatsby-sample test and related kustomization entry#712
Merged
Conversation
012xx
force-pushed
the
remove-test-gatsby-starter-default
branch
from
2b5a94b to
d55938f
Compare
…egicMerge and remove unused build-gatsby.sh
Contributor
Author
|
@takahiro-yamada |
takahiro-yamada
requested changes
May 1, 2026
takahiro-yamada
left a comment
takahiro-yamada
left a comment
There was a problem hiding this comment.
- Please update README.md too.
- Please write the PR description so that others can understand why this PR was opened, especially since this is a public repository.
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
Regarding the Gatsby description in the README, I thought it wouldn't be necessary to remove it because this PR doesn't mean we are dropping Gatsby support (as we are only removing the e2e tests). I did remove it from the examples, but if there is any reason why it should be removed elsewhere, please let me know your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Website-Operator supports gatsby, and for the sample files used in testing, it references the master branch of the external repository gatsbyjs/gatsby-starter-default.
website-operator/e2e/manifests/website/gatsby.yaml
Lines 12 to 13 in d72480e
Although dependency updates for the upstream seem to be handled automatically, I believe we should not, or do not need to, reference it directly based on the following facts:
In this PR, I am removing the relevant gatsby e2e tests and associated lines to eliminate the risks mentioned above.