Open
Conversation
54bfd0a to
ce9146f
Compare
Contributor
Author
|
I am pushing commits for 00d64ae because the CI is failing for reasons like https://github.com/cybozu-go/website-operator/actions/runs/24449488424/job/71434444985?pr=711. |
Open
pddg
requested changes
Apr 16, 2026
ce9146f to
b30019c
Compare
5736876 to
16321f4
Compare
pddg
reviewed
Apr 16, 2026
e24de5f to
4ca9a9b
Compare
pddg
reviewed
Apr 17, 2026
| load-images: | ||
| cd ../ && goreleaser release --clean --snapshot --skip=publish | ||
| cd ../ && cat .goreleaser.yml \ | ||
| | PLATFORM="linux/$(shell uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/')" \ |
Contributor
There was a problem hiding this comment.
Suggested change
| | PLATFORM="linux/$(shell uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/')" \ | |
| | PLATFORM="linux/$$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/')" \ |
Comment on lines
+2
to
+4
| RUN groupmod -g 10000 ubuntu \ | ||
| && usermod -u 10000 -g 10000 ubuntu \ | ||
| && chown -R 10000:10000 /home/ubuntu |
Contributor
There was a problem hiding this comment.
modifying current user's uid/gid may cause some problems.
Running as non-root user is important, not UID:GID=10000 is 10000.
Could we use the default ubuntu user (non-root) ?
4ca9a9b to
c787f51
Compare
… for repo-checker
- Replace deprecated dockers/docker_manifests with unified dockers_v2 - Update Dockerfile for platform-aware binary copying with $TARGETPLATFORM - Filter e2e build platforms to match host architecture
The previous image family included a uid/gid 10000 user, but the new base image does not. To match the new image’s existing user, run repo-checker as uid/gid 1000 and use /home/ubuntu for HOME and deploy-key mount, fixing SSH host key/config issues. Keep build/after-build workloads on uid/gid 10000 to remain compatible with zoetrope build images and avoid permission/no-user regressions.
c787f51 to
b29d57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the transfer of website-operator, the location for ghcr.io has changed to ghcr.io/cybozu-go/website-operator, so I have updated the references accordingly.
https://github.com/cybozu-go/website-operator/pkgs/container/website-operator
In addition, since there was an in-house container for ubuntu, I have updated that as well.
For this PR, I have only made the changes that can be easily addressed for now, and I plan to handle the API and CRD-related changes in a separate PR.