build: add missing workspace dependencies and fix links avatar URL - #162
Open
hesitling wants to merge 2 commits into
Open
build: add missing workspace dependencies and fix links avatar URL#162hesitling wants to merge 2 commits into
hesitling wants to merge 2 commits into
Conversation
|
@hesitling is attempting to deploy a commit to the cworld Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
It is difficult to define whether a package needs an explicit declaration, for example, project also used zod, which is also in Astro package. I truly understand the working ways of pnpm, but I may realize that explicit declarations can be a burden on dependency management. I’ve been busy lately, and when I’m done, I’ll think about whether I need those explicit statements. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes dependency and workspace issues that can break fresh installs/builds, and updates a links avatar URL that was causing image/build problems.
Changes
packages/puredependencies required by the bundledastro-purepackage at build timepnpm-workspace.yamlsopnpmrecognizespackages/pureas a workspace package and allows required native build steps (esbuild,sharp)public/links.jsonavatar URL fromcravatar.cntocn.cravatar.comWhy
The codebase already imports these modules from both the app and
packages/pure, but they were not fully declared inpackage.json. That makes installs/builds depend on existing local state instead of the repository manifest. This change makes the dependency graph explicit and reproducible.This change fixes missing direct dependency declarations.
The app and the local
astro-purepackage import modules such as@astrojs/markdown-remark,@unocss/preset-typography,rehype-stringify,remark-parse,remark-rehype,unified,shiki,rehype,ultrahtml, andvfile, but those packages were not fully declared in the correspondingpackage.jsonfiles. Builds only worked when those modules happened to be present transitively through other installed packages.This stayed hidden upstream because the repo is primarily developed with Bun, whose existing hoisted install layout can mask undeclared dependencies. In a stricter
pnpmsetup, especially oncepackages/pureis treated as a real workspace package, those phantom dependencies are no longer reliably resolvable, so install/build failures surface.The avatar URL update avoids failures caused by the previous host/redirect behavior when remote images are processed during build.
Testing
pnpm buildastro checkpassed with0 errorsand0 warnings