feat: visual notification inbox overlay UI (chrome + Jist rendering)#747
Draft
mahmoud-elmorabea wants to merge 1 commit into
Draft
feat: visual notification inbox overlay UI (chrome + Jist rendering)#747mahmoud-elmorabea wants to merge 1 commit into
mahmoud-elmorabea wants to merge 1 commit into
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## inbox-data-layer #747 +/- ##
======================================================
+ Coverage 69.51% 69.68% +0.16%
- Complexity 1001 1006 +5
======================================================
Files 169 169
Lines 5318 5330 +12
Branches 736 736
======================================================
+ Hits 3697 3714 +17
+ Misses 1349 1340 -9
- Partials 272 276 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
a8abc78 to
28499da
Compare
e703598 to
42304b7
Compare
|
|
42304b7 to
32fd8be
Compare
|
|
32fd8be to
037ce4c
Compare
|
|
037ce4c to
a176aba
Compare
|
|
a176aba to
ea75d4b
Compare
|
|
940e19f to
f7c3cf3
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ea75d4b to
3783710
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Notification Inbox overlay UI stacked on the data-layer PR: floating bell + unread badge + slide-out panel, each message rendered via Jist (type→template, typed properties→data, templates+theme), auto-mark-opened with in-flight dedupe, read-only get-messages + unopened-count, touch-capturing overlay, and empty/loading states. Consumes the internal
VisualInbox(headlessNotificationInboxleft intact).Scope: items 6–11. Deferred to follow-up: items 12–18 (click/action mapping, performAction host API, marking-read web parity, no-template fallback, chrome theming + dark, date format) and the branding
floatingIcon.svgbell (uses default bell for now).Interim: Jist referenced locally (TODO: switch to published artifact). iOS only: package floor temporarily raised 13→15 for the Jist dependency (Jist render
@available(iOS 15)-gated + 13/14 fallback; revert at Jist M0). Android: jist compiled in-tree + desugaring/minSdk override (TODO: published artifact).🤖 Generated with Claude Code