fix state trigger hold on unrelated state updates#847
Open
dmamelin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845.
The new
state_triggertreated unrelated state events as afalsetrigger condition. For entities likemedia_player, attribute-only updates can arrive while the watched state remains unchanged, for exampleplaying. Those updates could resetstate_hold, causing the trigger to never fire.This changes the new
state_triggerdecorator to ignore unrelated state events, matching the legacy trigger behavior. A regression check was added to test_state_trigger for attribute-only updates during state_hold.