Skip to content

Feature/312 suggestions#130

Merged
RK206 merged 46 commits into
developfrom
feature/312_suggestions
Feb 27, 2025
Merged

Feature/312 suggestions#130
RK206 merged 46 commits into
developfrom
feature/312_suggestions

Conversation

@anusharanganathan

@anusharanganathan anusharanganathan commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

fixes culturesofknowledge/emlo-project#312

Issues to address

  • In the model suggestions/models.py, there is

    • related_record and lines related to foreign key

      I did not know how to use this. So I created a field called related_record_int to store the id of the related record as an integer without creating any relation between models

    • Both of these exist in the model. It needs to either be updated to use the foreign key and delete the related_record_int or delete the lines about related record

  • The CSS for suggestion table head is not working - code

  • Commit issues

    If it would be useful, I am happy to create a new branch, copy over the changes or we could squash all the commits while merging

Things to do

  • Need to add permissions to submission
    • Supervisor / Editor / Contributing editor can add suggestions
    • Only supervisor / editor can resolve suggestions
    • Only owner or supervisor can delete suggestions
  • Add suggestions as an option to the menu

Things to do - AR

  • I have not created any tests. Happy to do that if you point me to what needs to be done
  • Need to add feature Suggest any changes to existing people, publication, location, repository and work record
    • When they click on resolve - it will open the form and the suggestion will appear somewhere on the page so the user can copy from it to make changes to the record
    • When they click on save, the suggestion will be marked as resolved (similar to new suggestion)

anusharanganathan and others added 30 commits February 11, 2025 13:50
@RK206 RK206 marked this pull request as ready for review February 27, 2025 10:40
@RK206 RK206 merged commit 2b05bcc into develop Feb 27, 2025
@RK206 RK206 deleted the feature/312_suggestions branch February 27, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants