Feature/312 suggestions#130
Merged
Merged
Conversation
…-edit-2 into feature/312_suggestions # Conflicts: # login/templates/login/dashboard.html # siteedit2/settings/base.py # siteedit2/urls.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes culturesofknowledge/emlo-project#312
Issues to address
In the model suggestions/models.py, there is
related_record and lines related to foreign key
I did not know how to use this. So I created a field called
related_record_intto store the id of the related record as an integer without creating any relation between modelsBoth of these exist in the model. It needs to either be updated to use the foreign key and delete the related_record_int or delete the lines about related record
The CSS for suggestion table head is not working - code
Commit issues
If it would be useful, I am happy to create a new branch, copy over the changes or we could squash all the commits while merging
Things to do
Things to do - AR
Suggest any changesto existing people, publication, location, repository and work record