Ensure client-secret reset submits as POST for non-admin client owners#964
Open
Copilot wants to merge 3 commits into
Open
Ensure client-secret reset submits as POST for non-admin client owners#964Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix reset client secret error for non-admin users
Ensure client-secret reset submits as POST for non-admin client owners
Jun 6, 2026
Portals
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-admin users could trigger “Reset client secret” from the UI, but the request path could degrade into a non-POST flow and hit a
405 Method Not Allowedon/clients/{id}/reset. As a result, secrets were not rotated and old credentials remained valid.Reset form hardening (server-rendered template)
action+method="post") in addition to htmx attributes./my-clients→ client details) and guarantees the reset endpoint receives POST requests.Coverage for non-admin owner flow
POSTto/clients/{uid}/reset