Skip to content

fix: improve error handling in similarity tools #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxcxjxhx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve error handling in similarity tools #3066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions slither/tools/similarity/encode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def load_contracts(dirname: str, ext: str | None = None, nsamples: int | None =
for x, y, files in walk:
for f in files:
if ext is None or f.endswith(ext):
r.append(x + "/".join(y) + "/" + f)
r.append(os.path.join(x, f))

if nsamples is None:
return r
Expand Down Expand Up @@ -225,7 +225,7 @@ def encode_contract(cfilename, **kwargs):
try:
slither = Slither(cfilename, **kwargs)
except Exception:
simil_logger.error("Compilation failed for %s using %s", cfilename, kwargs["solc"])
simil_logger.error("Compilation failed for %s using %s", cfilename, kwargs.get("solc", "unknown"))
return r

# Iterate over all the contracts
Expand Down
2 changes: 1 addition & 1 deletion slither/tools/similarity/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@ def plot(args: argparse.Namespace) -> None:
plt.savefig("plot.png", bbox_inches="tight")

except Exception:
logger.error(f"Error in {args.filename}")
logger.error(f"Error in {getattr(args, 'filename', '<unknown>')}")
logger.error(traceback.format_exc())
sys.exit(-1)
2 changes: 1 addition & 1 deletion slither/tools/similarity/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ def test(args: Namespace) -> None:
logger.info(format_table.format(*(list(x) + [score])))

except Exception:
logger.error(f"Error in {args.filename}")
logger.error(f"Error in {getattr(args, 'filename', '<unknown>')}")
logger.error(traceback.format_exc())
sys.exit(-1)
2 changes: 1 addition & 1 deletion slither/tools/similarity/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ def train(args: argparse.Namespace) -> None:
logger.info("Done!")

except Exception:
logger.error(f"Error in {args.filename}")
logger.error(f"Error in {getattr(args, 'filename', '<unknown>')}")
logger.error(traceback.format_exc())
sys.exit(-1)