Support CharLiteral in RangeLiteral#each - #17170
Draft
straight-shoota wants to merge 3 commits into
Draft
Conversation
straight-shoota
force-pushed
the
feat/rangeliteral.map
branch
from
July 27, 2026 19:38
d3c6d1e to
bb1661a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
RangeLiteral#eachand#mapand#to_aas well as{% for range %}only work with numeric ranges. This patch adds support for ranges ofCharLiteral, which we can iterate just likeNumberLiteral.Iterating
CharLiteralis useful for building lookup tables for characters. They are better readable than the equivalentNumberLiteralexpression.For example:
Theoretically, we could do the same for
StringLiteral, although I don't see a big use case for that.The first two commits are a bit of prefactoring. I'll probably extract them to independent PRs.