feat: Implement preferred line width to YAML builder(#17082) - #17141
Open
LaskaIDK wants to merge 3 commits into
Open
feat: Implement preferred line width to YAML builder(#17082)#17141LaskaIDK wants to merge 3 commits into
LaskaIDK wants to merge 3 commits into
Conversation
Member
|
I'm wondering if it's a good idea to pile config options directly onto all kinds of YAML serialization methods, or if a dedicated settings object would be better (#17082 (comment)). I suppose we could still merge this nevertheless, and figure out a concept for the configuration mechanism later. But I'd like to hear other's opinions on this. |
Contributor
Author
|
I saw the comment, but decided against it since it'd be best for now to not make one without hearing other maintainers on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented yaml_emitter_set_width into the YAML builder + a spec
Closes #17082